This repository has been archived by the owner on May 3, 2018. It is now read-only.
RFC: Added isolated Docker builder and runner #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current build setup requires root and installation of a ton of packages from pip on the local machine. With this PR, this can be done in a single-command with a DinD config and isolated builder. Currently only supports Ubuntu 16.04 but can be easily extended to others.
sgnn7
force-pushed
the
add_isolated_builder
branch
from
c29f735
to
51675af
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current build setup requires root and installation of a ton of packages
from pip on the local machine. With this PR, this can be done in a
single-command with a DinD config and isolated builder. Currently only
supports Ubuntu 16.04 but can be easily extended to others.
@wallrj Let me know what you think and feel free to relocate this in the tree if needed.