Upgrades to Django 3, Channels 2, and upgrade other packages #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bctrainers
reviewed
Sep 12, 2021
entrypoint.sh
Outdated
| @@ -15,5 +15,5 @@ echo "daphne" | |||
| ./manage.py runworker > runworker2.log 2>&1 & | |||
| ./manage.py runworker > runworker3.log 2>&1 & | |||
| ./manage.py runworker > runworker4.log 2>&1 & | |||
| daphne trunk_player.asgi:application --port 7055 --bind 127.0.0.1 | |||
| daphne trunk_player.asgi:channel_layer --port 7055 --bind 127.0.0.1 | |||
There was a problem hiding this comment.
It may be worthwhile adding --access-log /var/log/trunk-player/daphne_main.log --ping-interval 3 --ping-timeout 12 --proxy-headers to the daphne process command-line. Primarily --proxy-headers for the nginx stuff. Same would also apply to the supervisor.conf file.
There was a problem hiding this comment.
Hey, Just added and pushed that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Upgrades the pip packages to Django 3, Channels 2, and upgrade other packages - REF #104
Other Changes:
This should resolve the major security vulns
