Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context to get #96

Closed
wants to merge 5 commits into from
Closed

Add context to get #96

wants to merge 5 commits into from

Conversation

SCedricThomas
Copy link

fix #84

@SCedricThomas SCedricThomas self-assigned this May 5, 2023
@SCedricThomas SCedricThomas marked this pull request as ready for review May 5, 2023 08:36
@SCedricThomas SCedricThomas requested a review from ipfaze May 5, 2023 08:51
@ipfaze
Copy link
Contributor

ipfaze commented May 5, 2023

LGTM
But as it brings a breaking change, I would like the guidance of @EtienneM.
Etienne, do you think we can merge this as it is or the issue should be transform to cover the entire project to bring ctx context.Context to all methods it lacks of.
And then made a new release version 8.0.0?

EtienneM
EtienneM requested changes May 9, 2023
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see other context.Background calls in the library. I think all methods should be context-ified, and it should lead to a new major version.

ipfaze
ipfaze requested changes May 10, 2023
View reviewed changes
Copy link
Contributor

@ipfaze ipfaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See: #96 (review)

@ipfaze ipfaze mentioned this pull request May 24, 2023
Open
@ipfaze
Copy link
Contributor

ipfaze commented May 24, 2023

Closed this Pull-Request as the issue was redefined and sent back to the backlog in our project board.

@ipfaze ipfaze closed this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipfaze ipfaze ipfaze requested changes

@EtienneM EtienneM EtienneM requested changes

Assignees

@SCedricThomas SCedricThomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a context to all functions that does not have a context in parameters
3 participants
@SCedricThomas @ipfaze @EtienneM