Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a context to all functions that does not have a context in parameters #84

Open
ipfaze opened this issue Mar 10, 2023 · 3 comments
Open

Add a context to all functions that does not have a context in parameters #84

ipfaze opened this issue Mar 10, 2023 · 3 comments

Comments

@ipfaze
Copy link
Contributor

ipfaze commented Mar 10, 2023

The method Get defined here must take a ctx context.Context in parameters.
@guillaume-sc
Copy link

@ipfaze, I see the pull request has been merged. Do we need to do more on this topic?

@ipfaze
Copy link
Contributor Author

ipfaze commented Mar 23, 2023

@guillaume-sc, the merged pull request is the one that revealed the lack of context in the parameters of the Get method but the context is not yet defined in it.
So we still need to work on it 🙂

@SCedricThomas SCedricThomas mentioned this issue May 5, 2023
Closed
@ipfaze
Copy link
Contributor Author

ipfaze commented May 24, 2023

Updating the issue, as stated in our review.
We must context-ified all function that does not have a context in parameters.

This will lead to a new major release.

@ipfaze ipfaze changed the title Add context in Get(service string) function Add a context to all functions that does not have a context in parameters May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add context to get Scalingo/etcd-discovery
2 participants
@ipfaze @guillaume-sc