fix redshift/postgres beginning_of_all_times unknown ghost record values #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beginning_of_all_times_date was used instead of beginning_of_all_times, therefore if the defaults were not changed the ghost record value of the unknown records had 00:00:00 instead of 00:00:01 as time.
tkiehn
added
the
testing
|
Link to workflow summary: https://github.com/ScalefreeCOM/datavault4dbt-ci-cd/actions/runs/11048578076 RESULTS for Synapse: RESULTS for Postgres: RESULTS for BigQuery: RESULTS for Redshift: RESULTS for Snowflake: RESULTS for Exasol: |
remoteworkflow
bot
removed
the
testing
tderk
approved these changes
Sep 27, 2024
tkiehn
deleted the
fix-redshift-postgres-unknown-values-of-beginning-of-all-times
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
beginning_of_all_times_date was used instead of beginning_of_all_times, therefore if the defaults were not changed the ghost record value of the unknown records had 00:00:00 instead of 00:00:01 as time.
This results in incorrect filtering of the ghost records by timestamp downstream
Type of change