Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ghost record numeric defaults and add ghost record numeric values variables #251

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

tkiehn
Copy link
Collaborator

@tkiehn tkiehn commented Sep 5, 2024

Description

Change ghost record numeric defaults

The default values for numeric ghost records have been changed from 0 for unknown values and -1 for error values to -1 for unknown values and -2 for error values

Add ghost record numeric values variables

A global variable has been added that allows the changing of the numeric values for ghost records by the users

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation or included information that needs updates (e.g. in the Wiki)

@tkiehn tkiehn added the testing To trigger the automated test workflow as internal User. label Sep 5, 2024
@remoteworkflow
Copy link

remoteworkflow bot commented Sep 5, 2024

Link to workflow summary: https://github.com/ScalefreeCOM/datavault4dbt-ci-cd/actions/runs/10716132579


RESULTS for Synapse:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Postgres:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for BigQuery:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Redshift:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Snowflake:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Exasol:
❌ dbt-tests
✅ dbt-macro-tests

@tkirschke tkirschke merged commit ca5d7ac into main Sep 5, 2024
1 check passed
@tkirschke tkirschke deleted the add-ghost-record-numeric-values-variables branch September 5, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing To trigger the automated test workflow as internal User.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants