Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macros for global beginning and end of all times dates #249

Merged

Conversation

tkiehn
Copy link
Collaborator

@tkiehn tkiehn commented Sep 4, 2024

Description

The global variables for beginning and end of all times as a date are currently set as dictionaries inside the dbt_project.yml.
This PR introduces the macros that parse these variables and call them in the ghost_records_per_datatype.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update
    - Global variables need to be updated in the Wiki

How Has This Been Tested?

Pipeline when opening this PR

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation or included information that needs updates (e.g. in the Wiki)

@tkiehn tkiehn added the testing To trigger the automated test workflow as internal User. label Sep 4, 2024
@remoteworkflow
Copy link

remoteworkflow bot commented Sep 4, 2024

Link to workflow summary: https://github.com/ScalefreeCOM/datavault4dbt-ci-cd/actions/runs/10697407533


RESULTS for Synapse:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Postgres:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for BigQuery:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Redshift:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Snowflake:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Exasol:
❌ dbt-tests
❌ dbt-macro-tests

@remoteworkflow
Copy link

remoteworkflow bot commented Sep 4, 2024

Link to workflow summary: https://github.com/ScalefreeCOM/datavault4dbt-ci-cd/actions/runs/10697411534


RESULTS for Synapse:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Postgres:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for BigQuery:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Redshift:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Snowflake:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Exasol:
❌ dbt-tests
✅ dbt-macro-tests

@tkiehn tkiehn merged commit edceed4 into main Sep 4, 2024
1 check passed
@tkiehn tkiehn deleted the add-macros-for-global-beginning-and-end-of-all-times-dates branch September 4, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing To trigger the automated test workflow as internal User.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants