Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hub key renaming if there are different namings for bk and hkey #242

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

tkiehn
Copy link
Collaborator

@tkiehn tkiehn commented Aug 28, 2024

Description

fix hub key renaming if there are different namings for bk and hkey in the source_model: and the staging-model itself and there is only one source model

When only one source_model is specified inside the staging-macro but the source_model key-namings are differing from the definitions in the staging model the renaming would only happen when there are more than one source-model selected.

Related PR with more context: #239

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual testing via skeleton-project.

Checklist:

  • I have performed a self-review of my code

…n the source_model and the staging-model and there is only one source model
@tkiehn tkiehn requested a review from tkirschke August 28, 2024 14:23
Copy link
Contributor

@MatheHostel MatheHostel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with redshift adapter

@tkirschke tkirschke added the testing To trigger the automated test workflow as internal User. label Sep 2, 2024
@remoteworkflow
Copy link

remoteworkflow bot commented Sep 2, 2024

Link to workflow summary: https://github.com/ScalefreeCOM/datavault4dbt-ci-cd/actions/runs/10668335468


RESULTS for Synapse:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Postgres:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for BigQuery:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Redshift:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Snowflake:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Exasol:
❌ dbt-tests
❌ dbt-macro-tests

@tkirschke tkirschke merged commit e7c78ea into main Sep 2, 2024
1 check passed
@tkirschke tkirschke deleted the fix-hub-key-renaming-for-single-source-hubs branch September 2, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing To trigger the automated test workflow as internal User.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants