Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed double comma for Multi Active Hashkey calculation #184

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

tkirschke
Copy link
Member

@tkirschke tkirschke commented Jun 7, 2024

  • Line 25 in hash_columns.sql would produce double commas, since there is also a comma outside the "if"-block, in line 36. This leads to a SQL Fail.
  • Column names of Ghost Records in snowflake were not escaped
  • Hash Input Columns, that are derived/prejoined columns, were not properly excluded, because the UPPER() mapping in stage_processing_macros.sql was not applied to both lists

@tkirschke tkirschke requested a review from tkiehn June 7, 2024 06:45
Copy link
Collaborator

@tkiehn tkiehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find issues, looks good to me

@tkiehn tkiehn merged commit 555d102 into main Jun 11, 2024
@tkirschke tkirschke deleted the tkirschke-patch-5 branch September 11, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants