Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed combination of derived cols and prejoins in Snowflake #183

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Fixed combination of derived cols and prejoins in Snowflake #183

merged 2 commits into from
Jun 4, 2024

Conversation

tkirschke
Copy link
Member

  • The combination of Prejoins, and derived cols that rename columns, was not working properly, because not all columns were properly selected.

@tkirschke tkirschke requested a review from tkiehn June 4, 2024 13:26
@tkirschke
Copy link
Member Author

Successfully tested on Snowflake

tkiehn
tkiehn approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@tkiehn tkiehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes were tested on snowflake and are approved

@tkirschke tkirschke merged commit 4d1d779 into main Jun 4, 2024
@tkirschke tkirschke deleted the tkirschke-patch-4 branch September 11, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkiehn tkiehn tkiehn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkirschke @tkiehn