fix: standardize token count properties #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Rename token count properties from prompt_tokens/completion_tokens to input_tokens/output_tokens - Add Number() conversion for token counts in trace utilities - Ensure consistent token property naming across all files - Replicate changes from langtrace-internal PR #267
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
karthikscale3
approved these changes
Dec 12, 2024
karthikscale3
deleted the
devin/1733618373-fix-token-count-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Token Count Property Standardization
This PR standardizes token count properties across the codebase and adds proper number type conversion.
Changes
prompt_tokens/completion_tokenstoinput_tokens/output_tokensNumber()conversion for token counts in trace utilitiesFiles Changed
components/project/traces/conversation-row.tsxlib/crewai_trace_util.tslib/dspy_trace_util.tslib/trace_util.tsTesting
The changes have been tested locally to ensure proper token counting and type conversion.
Link to Devin run: https://preview.devin.ai/devin/28494df863c64c02b49edab465102056