Dylan/s3en 2418 add clear all button to filter dialog v2 #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanzuber-scale3
changed the base branch from
development
to
dylan/s3en-2401-ability-to-filter-by-user-for-metrics-and-traces
dylanzuber-scale3
merged commit 99168cb
into
dylan/s3en-2401-ability-to-filter-by-user-for-metrics-and-traces
dylanzuber-scale3
deleted the
dylan/s3en-2418-add-clear-all-button-to-filter-dialog-v2
branch
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 05ea863 in 5 minutes and 22 seconds
More details
- Looked at
999lines of code in17files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_mqcMUFNxs0M5U1dW
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 5 days left in your free trial, upgrade for $20/seat/month or contact us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Introduces a 'Clear All' button in the trace filter dialog to reset all selected filters, enhancing user experience in managing complex data queries.
Key points:
Generated with ❤️ by ellipsis.dev