Skip to content

Commit

Permalink
Upgrade to sbt 1.8.0
Browse files Browse the repository at this point in the history
- due to the scala-xml situation, this is now the only supported sbt version for the plugin. Fixes #498
- bump to scala 2.12.17 and 2.13.10
- bump bloop to 1.5.4
  • Loading branch information
oyvindberg committed Nov 13, 2022
1 parent 2f966b8 commit 42eccb8
Show file tree
Hide file tree
Showing 147 changed files with 171 additions and 161 deletions.
14 changes: 12 additions & 2 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ lazy val importer = project
Deps.coursier,
Deps.scalatest % Test,
),
// bloop hasn't upgraded to scala-xml 2 yet
libraryDependencySchemes ++= Seq(
"org.scala-lang.modules" %% "scala-xml" % VersionScheme.Always
),
Test / fork := true,
assembly / test := {},
assembly / mainClass := Some("org.scalablytyped.converter.Main"),
Expand All @@ -80,7 +84,13 @@ lazy val importer = project
lazy val cli = project
.dependsOn(importer)
.configure(baseSettings)
.settings(libraryDependencies += Deps.scopt)
.settings(
libraryDependencies += Deps.scopt,
// bloop hasn't upgraded to scala-xml 2 yet
libraryDependencySchemes ++= Seq(
"org.scala-lang.modules" %% "scala-xml" % VersionScheme.Always
),
)

lazy val `sbt-converter` = project
.dependsOn(`importer-portable`)
Expand Down Expand Up @@ -131,7 +141,7 @@ lazy val baseSettings: Project => Project =
url("https://github.com/oyvindberg"),
),
),
scalaVersion := "2.12.16",
scalaVersion := "2.12.17",
scalacOptions ~= (_.filterNot(Set("-Ywarn-unused:imports", "-Ywarn-unused:params", "-Xfatal-warnings"))),
/* disable scaladoc */
Compile / doc / sources := Nil,
Expand Down
2 changes: 1 addition & 1 deletion docs/library-developer.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Have a look at [mobx-slinky](https://github.com/ScalablyTyped/mobx-slinky)

## Requirements

**This plugin needs sbt 1.7.x**.
**This plugin needs sbt 1.8.x**.

Since we generate source code, it should work with any combination of
Scala 2.12 / 2.13 / 3.2.0 and Scala.js 1.11+
Expand Down
2 changes: 1 addition & 1 deletion docs/plugin.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ If you really want more than one conversion make sure to [shade](conversion-opti

## Requirements

**This plugin needs sbt 1.7.x**.
**This plugin needs sbt 1.8.x**.

Since we generate source code, it should work with any combination of
Scala 2.12 / 2.13 / 3.2.0+ and Scala.js 1.11+
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,15 +144,16 @@ class BloopCompiler private (
setup = None,
),
),
java = None,
sbt = None,
test = None,
platform = None,
resolution = None,
workspaceDir = None,
sourcesGlobs = None,
sourceRoots = None,
tags = None,
java = None,
sbt = None,
test = None,
platform = None,
resolution = None,
workspaceDir = None,
sourcesGlobs = None,
sourceRoots = None,
tags = None,
sourceGenerators = None,
),
)
os.makeDir.all(bloopFolder)
Expand Down
6 changes: 3 additions & 3 deletions project/Deps.scala
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ object Deps {
val sourcecode = "com.lihaoyi" %% "sourcecode" % "0.3.0"
val scalatest = "org.scalatest" %% "scalatest" % "3.2.14"
val fansi = "com.lihaoyi" %% "fansi" % "0.4.0"
val bloop = "ch.epfl.scala" %% "bloop-frontend" % "1.5.0"
val scalaXml = "org.scala-lang.modules" %% "scala-xml" % "1.3.0"
val bloop = "ch.epfl.scala" %% "bloop-frontend" % "1.5.4"
val scalaXml = "org.scala-lang.modules" %% "scala-xml" % "2.1.0"
val scopt = "com.github.scopt" %% "scopt" % "4.1.0"
val awssdkS3 = "software.amazon.awssdk" % "s3" % "2.15.28"
val coursier = "io.get-coursier" %% "coursier" % "2.0.16"
val coursier = "io.get-coursier" %% "coursier" % "2.1.0-RC1"

val circe: Seq[ModuleID] =
Seq(
Expand Down
2 changes: 1 addition & 1 deletion project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.1
sbt.version=1.8.0
1 change: 0 additions & 1 deletion project/plugins.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,3 @@ addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.4.6")
addSbtPlugin("com.eed3si9n" % "sbt-buildinfo" % "0.11.0")
addSbtPlugin("ch.epfl.scala" % "sbt-bloop" % "1.5.4")
addSbtPlugin("com.github.sbt" % "sbt-ci-release" % "1.5.11")
addSbtPlugin("org.xerial.sbt" % "sbt-sonatype" % "3.9.14") // remove on next release of sbt-ci-release
2 changes: 1 addition & 1 deletion release.sc
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ case class DemoRepo(repo: String, name: String)(implicit path: os.Path) {
None
case line => Some(line)
}
os.write.over(path / "project" / "build.properties", "sbt.version=1.7.0")
os.write.over(path / "project" / "build.properties", "sbt.version=1.8.0")
os.write.over(pluginsFile, newLines.mkString("\n"))
%.sbt("compile", "dist")
%.git("add", "-A")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,10 @@ object ScalablyTypedPluginBase extends AutoPlugin {
Global / Keys.onLoad := (state => {
val old = (Global / Keys.onLoad).value
Keys.sbtVersion.value match {
case valid if valid.startsWith("1.7") => old(state)
case valid if valid.startsWith("1.8") => old(state)
case invalid =>
sys.error(
s"This version of the ScalablyTyped plugin only supports 1.7.x. You're currently using $invalid",
s"This version of the ScalablyTyped plugin only supports 1.8.x. You're currently using $invalid",
)
}
}),
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.1
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.1
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.1
sbt.version=1.8.0
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package scalajs
import io.circe013.{Decoder, Encoder}

object Versions {
val sbtVersion = "1.7.2"
val sbtVersion = "1.8.0"

// this accepts any nightly or milestone with the same binversion as a major release. good enough for now
private val Version = "(\\d+).(\\d+).(\\d+).*".r
Expand Down Expand Up @@ -44,8 +44,8 @@ object Versions {
implicit val decodes: Decoder[Scala] = Decoder[String].map(Scala.apply)
}

val Scala212 = Scala("2.12.15")
val Scala213 = Scala("2.13.8")
val Scala212 = Scala("2.12.17")
val Scala213 = Scala("2.13.10")
val Scala3 = Scala("3.2.0")

case class ScalaJs(scalaJsVersion: String) {
Expand Down
2 changes: 1 addition & 1 deletion tests/antd/check-3/a/antd/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
2 changes: 1 addition & 1 deletion tests/aws-sdk/check-3/a/aws-sdk/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
2 changes: 1 addition & 1 deletion tests/babylon/check-3/b/babylon/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
2 changes: 1 addition & 1 deletion tests/babylon/check-3/n/node/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
2 changes: 1 addition & 1 deletion tests/bigint/check-3/b/bigint/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
2 changes: 1 addition & 1 deletion tests/bigint/check-3/s/std/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
2 changes: 1 addition & 1 deletion tests/chart.js/check-3/s/std/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
2 changes: 1 addition & 1 deletion tests/cldrjs/check-3/c/cldrjs/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
2 changes: 1 addition & 1 deletion tests/cldrjs/check-3/s/std/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
2 changes: 1 addition & 1 deletion tests/commander/check-3/n/node/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
2 changes: 1 addition & 1 deletion tests/commander/check-3/s/std/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
2 changes: 1 addition & 1 deletion tests/create-error/check-3/s/std/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
2 changes: 1 addition & 1 deletion tests/echarts/check-3/e/echarts/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
2 changes: 1 addition & 1 deletion tests/electron/check-3/e/electron/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
2 changes: 1 addition & 1 deletion tests/electron/check-3/n/node/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
2 changes: 1 addition & 1 deletion tests/electron/check-3/s/std/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
2 changes: 1 addition & 1 deletion tests/firebase/check-3/f/firebase/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
2 changes: 1 addition & 1 deletion tests/fp-ts/check-3/f/fp-ts/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
2 changes: 1 addition & 1 deletion tests/insight/check-3/i/insight/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
2 changes: 1 addition & 1 deletion tests/keyof/check-3/k/keyof/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
2 changes: 1 addition & 1 deletion tests/monaco-editor/check-3/s/std/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.7.2
sbt.version=1.8.0
Loading

0 comments on commit 42eccb8

Please sign in to comment.