Fix: Clean files #246
Merged
Fix: Clean files #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xquantum3labs
requested changes
Aug 12, 2024
| @@ -41,7 +41,7 @@ export const Faucet = () => { | |||
| useEffect(() => { | |||
| const checkChain = async () => { | |||
| try { | |||
| const providerInfo = await publicClient.getBlock(); | |||
| const providerInfo = await publicClient.getBlockWithTxHashes(); | |||
There was a problem hiding this comment.
it seems to me that this will be a heavier request, which we are not supposed to do when calling checkChain() only, why do we need txHashes ?
There was a problem hiding this comment.
we cant commit this file
|
Fixed! There are some |
metalboyrick
requested changes
Aug 12, 2024
0xquantum3labs
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name here
In order to make a smooth merge process form scaffold to speedrunstark, suggest to Clean files
Types of change
Comments (optional)