-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Add a placeholder if wallet not connected #368
Comments
Hi, @metalboyrick |
Hi @metalboyrick |
Hi 👋🏻 @metalboyrick I discovered that the issue was coming from this block of code in the Address.tsx component
If the loading check and the checkSumAddress check can be checked for differently that'd make the difference. As I've tested locally checking for the checkSumAddress after the block of code checking for the isLoading and displaying the skeleton I can fix this ETA: 30 Mins |
I would like to handle this issue. Here’s an overview of what I would do; |
About me My Approach in solving this issue ETA |
can i be assigned this issue? How i will tackle this
|
Hi, I’m a frontend developer experienced in TypeScript and JavaScript. I’ve reviewed the issue and understand the problem. Plan to Solve the Issue: Investigate the Address.tsx component to identify the current behavior when the wallet is not connected. I’m excited to help improve the user experience and look forward to contributing! |
Can I contribute to this one? |
Let me try this one! |
Can I be assigned to this? |
Can I take this from here? |
Would love to work on this issue I am a fullstack and blockchain developer having experience for more than 1.5 years and had worked on many projects from previous odhack my profile: (https://app.onlydust.com/u/SudiptaPaul-31) |
Hey! I'm Iteooluwakisi. |
Can I try solving this issue? |
I’d like to work on this. |
Hi, ETA: |
Hi, |
Would love to work on this issue I'm a fullstack and blockchain developer having experience for more than 1.5 years and worked on many projects from the previous odhack my profle:(https://app.onlydust.com/u/SudiptaPaul-31) |
I’d love to work on this task please, I'm Victor Peter, a front-end and smart contract developer. I promise to write a pixel perfect code. |
I’m interested in this one. |
Can I take this issue? I am a full stack and blockchain developer. ETA 24 hours |
Can I try solving this issue? |
Hi, I am a proficient blockchain developer, expert in Cairo, Rust, Solidity, Aptos, and web development. I have contributed to several projects like Chainevents and Arkprojects. Thank you! |
I'm Kimberly Cascante, a proud member of Dojo Coding! ⛩️ |
Can I start working on this? |
i would like to take this issue My approach to solve this issue is I'll split the initial conditional check in the Address component by separating !checkSumAddress from isLoading. When there's no address (wallet not connected), I'll display a placeholder component with a gray circle avatar and 'Connect wallet to view address' text. The loading skeleton will only show during actual loading states (when isLoading is true). This will prevent any confusion between disconnected and loading states. ETA : 12hrs |
Can I take care of this issue? |
hey sir i would love to work on this issue |
Issue Overview
Currently if the wallet component is not connected, it will stay as skeleton, which might make people think that it is still connecting when it is actually not connected.
Proposed Solutions or Ideas
See how you can update the
Address.tsx
component to achieve this goal.The text was updated successfully, but these errors were encountered: