Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a placeholder if wallet not connected #385

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

melnikga
Copy link

@melnikga melnikga commented Dec 13, 2024

[FEAT] Add a placeholder if wallet not connected #368

Fixes #368

Types of change

  • The text "You haven't connected your wallet yet" has been added to the skeleton component, and the logic of displaying the skeleton has also been changed
  • Mobile version

Comments (optional)

@melnikga
Copy link
Author

The mobile version is not ready yet, I will finish it in the next commit soon

@melnikga
Copy link
Author

Let me know if you are satisfied with this solution to the problem. In that case, I'll finish the mobile version and we can merge

@Nadai2010
Copy link
Collaborator

Hi @melnikga, please check that all CI tests are green, yarn format:check should correct the correct format.

We will check the placeholder changes and let you know.

Copy link
Collaborator

@Nadai2010 Nadai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the idea is to avoid having it stuck in a loading state, acting as if it’s "loading."

We just need it to display something short, like "Wallet not connected" or simila

  • No gray background and definitely no "Connect" button.

Captura desde 2024-12-14 06-41-36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Add a placeholder if wallet not connected
2 participants