Revert "fix: migrate to 0.49.0" #41
Conversation
This reverts commit cc99a1f.
| ktlint_version=$(ktlint --version) | ||
| echo "ktlint version: $ktlint_version" | ||
|
|
||
| if [ "$(printf '%s\n' "0.49.0" "$ktlint_version" | sort -V | head -n1)" = "0.49.0" ]; then | ||
| if [ "$INPUT_ANDROID" = true ]; then | ||
| export ANDROID="--code-style=android_studio" | ||
| else | ||
| export ANDROID="--code-style=intellij_idea" | ||
| fi | ||
| else | ||
| if [ "$INPUT_ANDROID" = true ]; then | ||
| export ANDROID=--android | ||
| fi | ||
| fi |
There was a problem hiding this comment.
On one hand --code-style=android_studio is what ktlint is saying to use with ktlint 0.49.0 but apparently this paramter has no effect (neither on CI, nor locally)
On the other hand --android is throwing error
ERROR com.pinterest.ktlint.cli.internal.KtlintCommandLine - Option '--android' / '-a' is deprecated and replaced with option '--code-style=android_studio'. Setting '.editorconfig' property 'ktlint_code_style=android_studio' might be a better idea for a project that is always to formatted with this code style.
but still seems to work just fine.
If this --code-style parameter really does not work with ktlint 0.49.0 (which was released few days ago) I would expect 0.49.1 to appear soon, meaning it would make more sense probably to keep action-ktlint as is hoping that problems will be solved soon on ktlint side
There was a problem hiding this comment.
I raised an issue pinterest/ktlint#1982
Let's see if it can get fixed soon.
There was a problem hiding this comment.
Issue will be fixed in next ktlint version. I will close the PR and raise another one to apply these changes starting v0.49.1
|
Replaced by #41 |
Reverts #40
It might be that the new flag is ineffective and
--androidstill works, so we need to roll back to avoid breaking changes.