Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #33: message formating #47

Closed
wants to merge 3 commits into from
Closed

Fixes #33: message formating #47

wants to merge 3 commits into from

Conversation

Alir3z4
Copy link
Member

@Alir3z4 Alir3z4 commented May 27, 2018

Fixes #33

@Alir3z4 Alir3z4 self-assigned this May 27, 2018
@Alir3z4 Alir3z4 requested a review from AmirSavand May 27, 2018 15:25
@AmirSavand
Copy link
Contributor

Wooo

@Alir3z4
Copy link
Member Author

Alir3z4 commented May 27, 2018

@AmirSavand does Angular let the messages to render in safe ? I mean rendering html data ?

@codecov
Copy link

codecov bot commented May 27, 2018 •
edited
Loading

Codecov Report

Merging #47 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #47      +/-   ##
=========================================
+ Coverage   94.62%   94.7%   +0.07%     
=========================================
  Files          22      22              
  Lines         428     434       +6     
=========================================
+ Hits          405     411       +6     
  Misses         23      23
Impacted Files Coverage Δ
chat/consumers.py 90.9% <100%> (+0.13%) ⬆️
chat/tests/test_chat_consumer.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8574a...501f0ed. Read the comment docs.

@AmirSavand
Copy link
Contributor

I have to configure it.

@Alir3z4
Copy link
Member Author

Alir3z4 commented May 27, 2018

I have to configure it.

Should we take care of it in this pull request or another ?

@AmirSavand
Copy link
Contributor

Another pull.

@AmirSavand
Copy link
Contributor

What about other converts? Like quote? or code?

@Alir3z4
Copy link
Member Author

Alir3z4 commented May 27, 2018

I see
I think this is not an efficient way.
This can be done via #48 way better.

@Alir3z4 Alir3z4 closed this May 27, 2018
@AmirSavand AmirSavand deleted the 33-message-formating branch May 27, 2018 15:44
@AmirSavand
Copy link
Contributor

Good call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmirSavand AmirSavand AmirSavand approved these changes

Assignees

@Alir3z4 Alir3z4

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alir3z4 @AmirSavand