fix: remove duplicate payjoin code in getAddressWithAmountAndLabel #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix #371 |
ethicnology
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some code that is executed when payjoinReceiver != null that was present two times in the same function, one time before checking
isLiquidand one time after checkingisLiquid. The code before the Liquid check was causing the issue and so I removed it, since if not Liquid, it will still be executed after this check.A more elaborate fix would also make sure the payjoinReceiver gets reset when isLiquid, but I think a bigger refactoring can eliminate this problem completely, so for now just removing the duplicate code before the check works as a quick fix.