-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tempo information to track metadata #368
Conversation
All 12 tests are passing but I don't have any idea on how to reflect that here. |
I don't see any changes to the tests - are they committed? |
I was waiting for your approval for creation of new tests for the BPM itself. I will create them ASAP |
hey @SathyaBhat, |
the tests seem to be still failing https://github.com/SathyaBhat/spotify-dl/actions/runs/7364433669/job/20044825544?pr=368
|
oh it's because i didn't update those test cases. let me fix those as well |
The code checks for the BPM in spotify.py and since the test cases are made custom rather than going through the library they don't have the tempo as a key-value pair. I can fetch the data of the music manually and assign the tempo to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor suggestions else looks good to me. thanks for your contribution!
fixes #367