Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom formats and make mp3 conversion optional #34

Merged
merged 2 commits into from
Mar 15, 2017

Conversation

shantanugoel
Copy link
Contributor

Scratching an itch for download part that I have for some time:

  1. MP3 conversion is not always desired since it may take a long time for big playlists and is also sometimes not possible on all systems (hate the ugly warning messages for missing ffmpeg for those cases ;))
  2. bestaudio downloads webm most of the time from youtube but most of the non-pc audio players (software as well as hw) can't play it, making mp3 a necessity. Added a way to use custom format strings for such cases (e.g. -f 'bestaudio[ext=m4a]/mp4' will download all songs in m4a natively which can be played by most players and is a pretty good quality format to boot).

@SathyaBhat
Copy link
Owner

Would skip conversion to mp3 as an optional thing be better for most? ie have MP3 conversion as default and pass params to skip conversion?

@shantanugoel
Copy link
Contributor Author

Yeah, that seems a reasonable default since we also have "bestaudio" as default which may download webm and thus needs conversion to mp3. I will make the appropriate change to keep conversion as default and provide option to skip.

@SathyaBhat
Copy link
Owner

Awesome, will wait for the change before merging in. thank you :) 👍

@shantanugoel
Copy link
Contributor Author

Added the change.

@SathyaBhat
Copy link
Owner

Thanks so much!

@SathyaBhat SathyaBhat merged commit 74c8b75 into SathyaBhat:master Mar 15, 2017
@shantanugoel shantanugoel deleted the format_str_optional_mp3 branch March 15, 2017 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants