Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Pass download directory along with -d option #5

Closed
kracekumar opened this issue Jan 24, 2016 · 8 comments
Closed

Suggestion: Pass download directory along with -d option #5

kracekumar opened this issue Jan 24, 2016 · 8 comments
Assignees

Comments

@kracekumar
Copy link
Contributor

-d option downloads the song in directory from where the command is run. Passing explicit directory option saves time in moving the files post download and cleanup. This will be handy when the command is run from cron job.

@kracekumar
Copy link
Contributor Author

Other option is to write a shell script and move the .mp3 to destination directory like

python spotify-dl -d
mv *.mp3 ~/Music

@SathyaBhat
Copy link
Owner

Good suggestion, I've had this thought to have it downloaded elsewhere but never got to it.

@SathyaBhat SathyaBhat self-assigned this Jan 25, 2016
@mr-karan
Copy link
Collaborator

Please take a look at this

@kracekumar
Copy link
Contributor Author

Above mentioned method will fail on Linux. Better to interpolate the value
passed by the user.

On Thu, Jan 28, 2016 at 12:16 PM, Karan Sharma [email protected]
wrote:

Please take a look at this
https://github.com/mr-karan/spotify-dl/commit/aa85eca865733aba54b1d182fabbd07a411d2641


Reply to this email directly or view it on GitHub
#5 (comment)
.

Regards
Kracekumar Ramaraj
http://kracekumar.com

@mr-karan
Copy link
Collaborator

^ I tried it on my system (Arch Linux), it worked as expected. Here

@mr-karan
Copy link
Collaborator

I can write another function which will pass the user specified directory to outtmpl. Do you suggest that would be better ?

@kracekumar
Copy link
Contributor Author

Yes. Passing the user supplied option will be better.

On Thu, Jan 28, 2016 at 12:43 PM, Karan Sharma [email protected]
wrote:

I can write another function which will pass the user specified directory
to outtmpl. Do you suggest that would be better ?


Reply to this email directly or view it on GitHub
#5 (comment)
.

Regards
Kracekumar Ramaraj
http://kracekumar.com

@mr-karan
Copy link
Collaborator

I have made the changes. Please check this. Sorry about a typo, which has been fixed in later commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants