Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The PyPi archive is missing requirements.txt file #225

Closed
judaew opened this issue Nov 4, 2021 · 2 comments · Fixed by #234
Closed

The PyPi archive is missing requirements.txt file #225

judaew opened this issue Nov 4, 2021 · 2 comments · Fixed by #234
Assignees
@SathyaBhat
Labels
bug

Comments

@judaew
Copy link
Contributor

judaew commented Nov 4, 2021

Describe the bug

requirements.txt file is missing during build from PyPI. At build time, pip is not used to download dependencies, as MacPorts build ports in an isolated environment. The workaround at the moment is to create this file myself.

To Reproduce

Download archive from PyPi, run setup.py.

Expected behavior

The app is installed correctly without error on the missing requirements.txt file.

Desktop (please complete the following information):

  • OS: macOS 12.0.1
  • Python version: Python 3.9.7 (MacPorts)
@judaew judaew added the bug label Nov 4, 2021
@judaew judaew mentioned this issue Nov 4, 2021
Merged
11 tasks
@SathyaBhat
Copy link
Owner

Thanks for the report, will take a look

@judaew
Copy link
Contributor Author

judaew commented Nov 6, 2021

Thanks for a great project!

@SathyaBhat SathyaBhat self-assigned this Jan 17, 2022
SathyaBhat added a commit that referenced this issue Jan 22, 2022
@SathyaBhat
add manifest file so pypi archive has requirements.txt
60e6f3d 
fixes #225
@SathyaBhat SathyaBhat mentioned this issue Jan 22, 2022
Merged
SathyaBhat added a commit that referenced this issue Jan 22, 2022
@SathyaBhat
add manifest file so pypi archive has requirements.txt (#234)
5e4dd38 
fixes #225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SathyaBhat SathyaBhat

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add manifest file so pypi archive has requirements.txt SathyaBhat/spotify-dl
2 participants
@SathyaBhat @judaew