Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper function to infer data dir #255

Merged

Conversation

FlorisCalkoen
Copy link
Contributor

@FlorisCalkoen FlorisCalkoen commented May 21, 2024

@2320sharon, feel free to accept/reject this change. You might find it helpful in determining the CoastSeg directory path. The function returns a pathlib object, which automatically handles different operating systems. You can find the implementation here.

I have temporarily left a few lines inside if __name__ == "__main__", so you can quickly check how/if it works.

This might resolve #246 (comment)

@FlorisCalkoen
Copy link
Contributor Author

Btw, apologies for formatting some of your code.. my automatic formatting was still on.

@2320sharon 2320sharon self-assigned this Jun 3, 2024
@2320sharon 2320sharon added enhancement New feature or request labels Jun 3, 2024
@2320sharon
Copy link
Collaborator

@FlorisCalkoen

Thank you for you this code I'll add this to CoastSeg so that it can automatically read from the correct data directory. The code in this PR works great!

@2320sharon 2320sharon merged commit 6048233 into SatelliteShorelines:main Jun 6, 2024
1 of 6 checks passed
@2320sharon
Copy link
Collaborator

Thank you for this PR Floris. I merged in your pull request to add you to the list of contributors, but I ended up moving your code out of common.py to core_utilities.py. This code is super helpful to have in CoastSeg, so thank you for providing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples folder contains data
2 participants