Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.16.z] Rely on dynaconf to render the config based on is_ipv6 setting #16923

Open
wants to merge 1 commit into
base: 6.16.z
Choose a base branch
from

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #16886

Problem Statement

The REPOS section of the config contains -ipv4 hostnames despite the is_ipv6 setting being set to True. This happens because we are looping through the non-templatized/non-formatted configuration loaded by the dynaconf YAML loader:

all_settings = settings.loaded_by_loaders.items()

Since the REPOS config section contains several templates, either @format or @jinja, injecting a string containing -ipv4, and since our algorithm uses the raw config file value loaded by the YAML loader, we are not able to detect this case and change these URLs and hostnames to -ipv6.

Solution

The proposed solution is to shift to a different approach - from mutating settings by an algorithm in robottelo to creating a self-contained configuration structure and including IPv4 and IPv6 URLs and hostnames in the config. Based on the IS_IPV6 setting, templatize the value of the actual hostname/URL config field.

Related Issues

https://issues.redhat.com/browse/SAT-29304
satellite-jenkins!1545

@Satellite-QE Satellite-QE added the 6.16.z Introduced in or relating directly to Satellite 6.16 label Nov 14, 2024
@Satellite-QE Satellite-QE requested a review from a team as a code owner November 14, 2024 20:21
@Satellite-QE Satellite-QE added Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants