Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert activation key upgrade scenario to new format #16772

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

synkd
Copy link
Contributor

@synkd synkd commented Oct 24, 2024

Problem Statement

The activation key upgrade scenario is currently failing and uses the old upgrade test format.

Solution

Convert the test to the new format using the shared_resource framework and converting the pre-upgrade test to a pytest fixture.

Remove entitlement-related steps as entitlement mode has been removed from Satellite 6.16+.

Related Issues

This test currently fails on the final org.delete() step due to SAT-28990.

@synkd synkd self-assigned this Oct 24, 2024
@synkd synkd added Upgrades Issues and PRs related to upgrades CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Oct 24, 2024
@synkd
Copy link
Contributor Author

synkd commented Oct 24, 2024

trigger: test-robottelo
pytest: tests/new_upgrades/test_activation_key.py::test_ak_upgrade_scenario

1 similar comment
@devendra104
Copy link
Member

trigger: test-robottelo
pytest: tests/new_upgrades/test_activation_key.py::test_ak_upgrade_scenario

@synkd
Copy link
Contributor Author

synkd commented Nov 1, 2024

trigger: test-robottelo
pytest: tests/new_upgrades/test_activation_key.py

@synkd
Copy link
Contributor Author

synkd commented Nov 5, 2024

trigger: test-robottelo
pytest: tests/new_upgrades/test_activation_key.py
env:
BROKER_SSH_BACKEND: hussh

@synkd synkd added the 6.13.z Introduced in or relating directly to Satellite 6.13 label Nov 5, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9277
Build Status: UNSTABLE
PRT Comment: pytest tests/new_upgrades/test_activation_key.py --external-logging
Test Result : ================= 1 failed, 18 warnings in 2556.00s (0:42:36) ==================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Nov 5, 2024
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

I have thrown a couple of proposals for improvement but I understand they are out of the scope of this PR and should be rather handled by product teams.

Comment on lines 66 to 68
ak = target_sat.api.ActivationKey(
content_view=cv, organization=org, name=f'{test_name}_ak'
).create()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creation should fail since 6.17 (both, CV and LCE, is required). Could we make this creation a bit future-proof by providing it with the Library LCE?

Suggested change
ak = target_sat.api.ActivationKey(
content_view=cv, organization=org, name=f'{test_name}_ak'
).create()
ak = target_sat.api.ActivationKey(
content_view=cv, environment=org.library.id, organization=org, name=f'{test_name}_ak'
).create()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsedmik Sure thing, thanks for the feedback. My first thought was that we might want to create a new LCE, but since the post-upgrade section deletes the org at the end, I don't think that's actually necessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@synkd That was my first thought too, but didn't want to bother with that and CV promotion. Library will do job too with less pain.

tests/new_upgrades/test_activation_key.py Show resolved Hide resolved
@synkd synkd force-pushed the convert_ak_upgrade_scenario branch from f73933a to 9ad12b8 Compare November 13, 2024 15:16
@synkd
Copy link
Contributor Author

synkd commented Nov 13, 2024

trigger: test-robottelo
pytest: tests/new_upgrades/test_activation_key.py
env:
BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9355
Build Status: UNSTABLE
PRT Comment: pytest tests/new_upgrades/test_activation_key.py --external-logging
Test Result : ================= 1 failed, 18 warnings in 2734.19s (0:45:34) ==================

@synkd synkd force-pushed the convert_ak_upgrade_scenario branch from 9ad12b8 to da9ab87 Compare November 13, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR Upgrades Issues and PRs related to upgrades
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants