Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.12.z] Switch SATELLITE_SERVICES to a list #11525

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #11522

Solving this error we were seeing in the Installer pipeline that was preventing the whole pipeline from running:

Different tests were collected between gw0 and gw1. The difference is:
--- gw0

+++ gw1

@@ -3,16 +3,16 @@

 tests/foreman/destructive/test_installer.py::test_positive_mismatched_satellite_fqdn
 tests/foreman/installer/test_installer.py::test_positive_selinux_foreman_module
 tests/foreman/installer/test_installer.py::test_positive_check_installer_service_running[dynflow-sidekiq@orchestrator]
-tests/foreman/installer/test_installer.py::test_positive_check_installer_service_running[dynflow-sidekiq@worker-1]
-tests/foreman/installer/test_installer.py::test_positive_check_installer_service_running[postgresql]
 tests/foreman/installer/test_installer.py::test_positive_check_installer_service_running[pulpcore-content]
 tests/foreman/installer/test_installer.py::test_positive_check_installer_service_running[dynflow-sidekiq@worker-hosts-queue-1]
+tests/foreman/installer/test_installer.py::test_positive_check_installer_service_running[foreman]
+tests/foreman/installer/test_installer.py::test_positive_check_installer_service_running[dynflow-sidekiq@worker-1]
+tests/foreman/installer/test_installer.py::test_positive_check_installer_service_running[pulpcore-api]
+tests/foreman/installer/test_installer.py::test_positive_check_installer_service_running[pulpcore-worker@*]
+tests/foreman/installer/test_installer.py::test_positive_check_installer_service_running[postgresql]
+tests/foreman/installer/test_installer.py::test_positive_check_installer_service_running[httpd]
 tests/foreman/installer/test_installer.py::test_positive_check_installer_service_running[tomcat]
-tests/foreman/installer/test_installer.py::test_positive_check_installer_service_running[pulpcore-worker@*]
-tests/foreman/installer/test_installer.py::test_positive_check_installer_service_running[foreman]
-tests/foreman/installer/test_installer.py::test_positive_check_installer_service_running[httpd]
 tests/foreman/installer/test_installer.py::test_positive_check_installer_service_running[foreman-proxy]
-tests/foreman/installer/test_installer.py::test_positive_check_installer_service_running[pulpcore-api]
 tests/foreman/installer/test_installer.py::test_positive_check_installer_hammer_ping
 tests/foreman/installer/test_installer.py::test_installer_options_and_sections[params]
 tests/foreman/installer/test_installer.py::test_installer_options_and_sections[sections]
To see why this happens see Known limitations in documentation

See pytest-dev/pytest-xdist#432 for more details. Seems like the test generation happens twice and compares when we split between workers, and pytest expects them to all be in the same order. Switching to a list ensures our items always come out in the same order.

@Satellite-QE Satellite-QE added 6.12.z Introduced in or relating directly to Satellite 6.12 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels May 23, 2023
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/installer/test_installer.py::test_positive_check_installer_service_running -n 2

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label May 23, 2023
@Griffin-Sullivan
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/installer/test_installer.py::test_positive_check_installer_service_running

@JacobCallahan JacobCallahan merged commit 59780f1 into 6.12.z May 23, 2023
@JacobCallahan JacobCallahan deleted the cherry-pick-6.12.z-164472431b61e9f5a5813c2c0de0bdb05e1443d3 branch May 23, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z Introduced in or relating directly to Satellite 6.12 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants