Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

foolproof the fitter against bump's antics #3172

Open
wants to merge 4 commits into
base: release_6.0.1
Choose a base branch
from
Open

foolproof the fitter against bump's antics #3172

wants to merge 4 commits into from
+15 −3

Conversation

rozyczko
Copy link
Member

@rozyczko rozyczko commented Jan 8, 2025

Description

Added guards against bad results returned by bumps in case fitting is canceled.

Fixes #3147

How Has This Been Tested?

Local testing on win10

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@rozyczko rozyczko added the Defect Bug or undesirable behaviour label Jan 8, 2025
@olihammond olihammond linked an issue Jan 9, 2025 that may be closed by this pull request
Failed S(Q) fitting causes loss of function #3147
Open
@butlerpd butlerpd added Discuss At The Call Issues to be discussed at the fortnightly call SasView 6.0.1 labels Jan 13, 2025
@butlerpd butlerpd requested a review from olihammond January 17, 2025 19:58
@butlerpd
Copy link
Member

Ollie says he still needs to do some functionality review before approving

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-wilkins lucas-wilkins lucas-wilkins approved these changes

@olihammond olihammond Awaiting requested review from olihammond

Assignees
No one assigned
Labels
Defect Bug or undesirable behaviour Discuss At The Call Issues to be discussed at the fortnightly call SasView 6.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed S(Q) fitting causes loss of function
4 participants
@rozyczko @butlerpd @lucas-wilkins @krzywon