Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing optimizer #2941

Closed

Conversation

wpotrzebowski
Copy link
Contributor

@wpotrzebowski wpotrzebowski commented Jul 4, 2024

Description

Should fix issue related to changing optimizer.
(This is still a work in progress. It only seems to work after restarting SasView)

Fixes # (issue/issues) #2889

How Has This Been Tested?

Run fit with one optimizer (e.g. lm) then change optimizer and run again.

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@wpotrzebowski wpotrzebowski added the SasView 6.0.0 Required for 6.0.0 release label Jul 11, 2024
@lucas-wilkins lucas-wilkins linked an issue Jul 18, 2024 that may be closed by this pull request
@wpotrzebowski
Copy link
Contributor Author

This issue has been magically solved by some other fix. Closing it and will reopen if it turns out that is not fully resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SasView 6.0.0 Required for 6.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot change fitting optimizer
1 participant