Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

67: Fix broken unit test(s) #68

Merged
merged 1 commit into from
Apr 23, 2024
Merged

67: Fix broken unit test(s) #68

merged 1 commit into from
Apr 23, 2024

Conversation

krzywon
Copy link
Collaborator

@krzywon krzywon commented Apr 23, 2024

This fixes the broken unit tests related to remote data.

Fixes #67

butlerpd
butlerpd approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@butlerpd butlerpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. A good improvement for the future I think. given the builds are now passing I think this should be merged asap IMO

@krzywon krzywon merged commit e742ada into release_0.9.0 Apr 23, 2024
18 checks passed
@krzywon krzywon deleted the 67-remote-unit-tests branch April 23, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butlerpd butlerpd butlerpd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krzywon @butlerpd