-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diverging cmap #698
Diverging cmap #698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together. I left a couple of comments that will have some minor changes throughout the PR but I didn't end up commenting everywhere.
Let me know if you have any questions.
I think that would solve the issues you raised. Thank you for your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for working on this - looks good to me! I've left a few minor suggestions.
Lastly, can you add an example in the Examples
section of the docstring in imgplot
. It will help with feature discovery. If you would like to do it as a separate PR, I'm open to that too.
I adressed the changes you proposed, which seemed reasonable. The stuff with the comments was a mistake, it's now solved. I also added the example in the docstring of imgplot, it didn't seem to be very hard at all, so it's not an issue. The only thing i worry about is if the example is meaningful enough, but it shows the feature so I think it's ok. Thanks again for you feedback. |
The example looks good for now. Thanks for working on this. I'll release it as part of v0.9.0 |
New arguments have been added called
diverging
andvmaxabs
. They were added to the following functions:_SetupImage
,imgplot
,imghist
,filterplot
andImageGrid
.The argument
diverging
forces vmin to be equal to -vmax, ensuring that diverging colormaps are displayed correctly, mapping the middle value to 0. The argumentvmaxabs
sets vmax to vmaxabs and vmin to -vmaxabs.I added documentation and unit tests to everything that was needed.
This implements the features discussed in issue #697.