Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

despine/respine globally using despine parameter in set_image() #56

Merged
merged 6 commits into from
Sep 24, 2020

Conversation

SarthakJariwala
Copy link
Owner

This PR adds new parameter despine to set_image() which allows global despining of image axes and colorbar axes.

despine parameters in individual functions still hold (but default is now None) and will be given preference over global state if not specified as None.

isns.despine() is still available for use as general utility function (Note that isns.despine() does not change the global state)

@SarthakJariwala SarthakJariwala added the enhancement New feature or request label Sep 24, 2020
@SarthakJariwala SarthakJariwala added this to the v0.4 milestone Sep 24, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #56 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   94.48%   94.58%   +0.09%     
==========================================
  Files           8        8              
  Lines         635      646      +11     
  Branches      151      156       +5     
==========================================
+ Hits          600      611      +11     
  Misses         18       18              
  Partials       17       17              
Impacted Files Coverage Δ
src/seaborn_image/_filters.py 100.00% <ø> (ø)
src/seaborn_image/_grid.py 93.52% <ø> (ø)
src/seaborn_image/_context.py 100.00% <100.00%> (ø)
src/seaborn_image/_core.py 93.27% <100.00%> (+0.55%) ⬆️
src/seaborn_image/_general.py 95.28% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bde68f...b27c65a. Read the comment docs.

@SarthakJariwala SarthakJariwala merged commit 00b81ec into master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants