-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate FilterGrid
, Python 3.6 and 3.7
#371
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarthakJariwala
added
dependencies
Pull requests that update a dependency file
removal
Remove from api
labels
Apr 19, 2022
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
==========================================
+ Coverage 96.93% 96.95% +0.01%
==========================================
Files 9 9
Lines 784 788 +4
Branches 204 204
==========================================
+ Hits 760 764 +4
Misses 11 11
Partials 13 13
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FilterGrid
is deprecated and will be removed in a future release.Use
ParamGrid
instead ofFilterGrid
with the same arguments.Docs and examples have been updated to reflect this.
Closes #234
Python 3.6 and 3.7 are also removed from supported versions. (Closes #228)
Versions supported- Python 3.8+ (Testing is also now on 3.8+)
This is mainly due to end of life of 3.6 and NumPy dropping support for 3.7 in its latest release which is required for passing safety vulnerabilities checks.