Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate FilterGrid, Python 3.6 and 3.7 #371

Merged
merged 19 commits into from
Apr 20, 2022
Merged

Deprecate FilterGrid, Python 3.6 and 3.7 #371

merged 19 commits into from
Apr 20, 2022

Conversation

SarthakJariwala
Copy link
Owner

@SarthakJariwala SarthakJariwala commented Apr 19, 2022

FilterGrid is deprecated and will be removed in a future release.

Use ParamGrid instead of FilterGrid with the same arguments.

Docs and examples have been updated to reflect this.

Closes #234


Python 3.6 and 3.7 are also removed from supported versions. (Closes #228)

Versions supported- Python 3.8+ (Testing is also now on 3.8+)

This is mainly due to end of life of 3.6 and NumPy dropping support for 3.7 in its latest release which is required for passing safety vulnerabilities checks.

@SarthakJariwala SarthakJariwala added dependencies Pull requests that update a dependency file removal Remove from api labels Apr 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022

Codecov Report

Merging #371 (34b1dac) into master (6b19479) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
+ Coverage   96.93%   96.95%   +0.01%     
==========================================
  Files           9        9              
  Lines         784      788       +4     
  Branches      204      204              
==========================================
+ Hits          760      764       +4     
  Misses         11       11              
  Partials       13       13              
Impacted Files Coverage Δ
src/seaborn_image/_grid.py 98.58% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b19479...34b1dac. Read the comment docs.

@SarthakJariwala SarthakJariwala added this to the v0.5 milestone Apr 20, 2022
@SarthakJariwala SarthakJariwala merged commit ccbaa03 into master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file removal Remove from api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate FilterGrid : Rename to ParamGrid Drop support for python 3.6, 3.7
2 participants