Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kit inherits abilities from base class when multikits already exist. #20

Closed
SarahG-579462 opened this issue Dec 26, 2022 · 2 comments
Closed
Labels
bug Something isn't working Minor

Comments

@SarahG-579462
Copy link
Owner

E.g. if multi Eldritch Knight from Artisan's Kitpack is installed, then Dreadnaught/Lathander gains Rapid Shot and Expertise.

@SarahG-579462 SarahG-579462 added Minor bug Something isn't working labels Dec 26, 2022
@SarahG-579462
Copy link
Owner Author

see #2, a similar issue that took a while to fix.

@SarahG-579462
Copy link
Owner Author

Fix would be:
1- check if QD_Multi already exists
2- if not, create it
3- for every unique kit in qd_multi, plus the base class, add the base class abilities as effects

(currently I only do 2 and 3 for the base class)

Will also need a fix for merging clabs

if I plan on making something like Eldritch Knight/Cleric kits possible, I might need a different architecture. Problem for later...

SarahG-579462 added a commit that referenced this issue Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Minor
Projects
None yet
Development

No branches or pull requests

1 participant