wip/run custom scripts #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapted Daniel Bystedt's approach of adding bake passes for adding custom scripts to be executed during Transmogrification.
Added operator to remove custom scripts. Improved UI of custom scripts and normalized to current Transmogrifier UI conventions.
Renamed classes to follow standards. Split Custom_Scripts.py into existing, respective modules.
Custom scripts are now written to Settings.json as a list of lists of values of custom scripts. Also renamed custom script class properties with a "script_" prefix.
Tested and approved that custom scripts run properly during conversion.
Instead of "Script 1", "Script 2", etc.; use the script file name as the title of each custom script box in the UI.
Read & add custom scripts from a Transmogrifier preset. Add warning icons and titles to custom scripts that can't be found or are not Python files. Stop converter if paths don't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Users to write their own scripts to further extend/customize Transmogrifier.
Closes #7