Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website look changed #54

Merged
merged 51 commits into from
Oct 5, 2022
Merged

Website look changed #54

merged 51 commits into from
Oct 5, 2022

Conversation

aryan-upa
Copy link
Contributor

There are some site changes, basically changing the look and feel of it.

Aryan Upadhyay and others added 9 commits October 2, 2022 18:22
Revert "Updated Classes"
9272678 
This reverts commit 8e872db.
Merge remote-tracking branch 'origin/master'
4e4b551 
# Conflicts:
#	out/production/Drifty/DefaultDownloadFolderLocationFinder$StreamReader.class
#	out/production/Drifty/DefaultDownloadFolderLocationFinder.class
#	out/production/Drifty/Drifty_CLI.class
Merge remote-tracking branch 'origin/master'
d507042
Merge remote-tracking branch 'origin/master'
9e8f06e
Created style.css and shifted css code in index.html to this file.
bceb7db
@aryan-upa
Merge branch 'SaptarshiSarkar12:master' into master
eaf501a
Revert "Created style.css and shifted css code in index.html to this …
b571019 
…file."

This reverts commit bceb7db.
Major website revamp and style change.
f23448b
Merge remote-tracking branch 'origin/master'
52ba05d 
# Conflicts:
#	Website/index.html
@aryan-upa aryan-upa mentioned this pull request Oct 4, 2022
Closed
@aryan-upa
Copy link
Contributor Author

Screenshots [ Major updates are in hover as well ]

ss1
ss2
ss3
ss4

@aryan-upa
Copy link
Contributor Author

https://aryan-upa.github.io/Drifty/
you can see working link here.

@SaptarshiSarkar12
Copy link
Owner

@aryan-upa Please make some required changes here. The text is not visible in dark mode.
image

@SaptarshiSarkar12 SaptarshiSarkar12 linked an issue Oct 5, 2022 that may be closed by this pull request
[FEATURE] Change the look and feel of website #53
Closed
@SaptarshiSarkar12
Copy link
Owner

@aryan-upa Also you need to make a change over here. The icons are not properly visible. Please specify whether the below image is in light or dark mode.
image

@SaptarshiSarkar12
Copy link
Owner

Also, please fix this. "Demonstration" word gets cut when i resize the screen to a smaller size. And the video doesn't Autoplay.
image

@aryan-upa
Copy link
Contributor Author

working...

@aryan-upa
Copy link
Contributor Author

@aryan-upa Also you need to make a change over here. The icons are not properly visible. Please specify whether the below image is in light or dark mode. image

this is in dark mode, I didn't actually changed anything there.

@SaptarshiSarkar12
Copy link
Owner

@aryan-upa Also you need to make a change over here. The icons are not properly visible. Please specify whether the below image is in light or dark mode. image

this is in dark mode, I didn't actually changed anything there.

Please change the footer background from white to black and in light mode, change it from black to white and please make those icons in the footer more prominent

@SaptarshiSarkar12
Copy link
Owner

@aryan-upa Please change the "dark mode button" to this - https://codepen.io/aliceyt/pen/eYpJobY

@SaptarshiSarkar12
Copy link
Owner

@aryan-upa Please change the "dark mode button" to this - https://codepen.io/aliceyt/pen/eYpJobY

Please make the required changes, then , i shall review it.

@aryan-upa
Copy link
Contributor Author

Although it looks cool, but don't you think it'll have it's own impact on site speed.

@aryan-upa
Copy link
Contributor Author

aryan-upa commented Oct 5, 2022 •
edited
Loading

all done.

working:- https://aryan-upa.github.io/Drifty/

@SaptarshiSarkar12
Copy link
Owner

Although it looks cool, but don't you think it'll have it's own impact on site speed.

But, it has improved some performance than the previous one, check below images. (I have made a report using "Lighthouse" in MS Edge)

Previous one -

image

New one -

image

SaptarshiSarkar12
SaptarshiSarkar12 approved these changes Oct 5, 2022
View reviewed changes
Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Thanks for contributing 🚀 🚀 🚀

@SaptarshiSarkar12 SaptarshiSarkar12 merged commit 9cc6398 into SaptarshiSarkar12:master Oct 5, 2022
@SaptarshiSarkar12 SaptarshiSarkar12 added the hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest label Oct 5, 2022
@SaptarshiSarkar12 SaptarshiSarkar12 changed the title Site change Commit. Website look changed Mar 20, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 added feature ✨ New feature request or addition Website 🌐 Issues/Pull Requests regarding Website labels Mar 20, 2023
SaptarshiSarkar12 added a commit that referenced this pull request Jul 6, 2023
@SaptarshiSarkar12
Merge pull request #54 from aryan-upa/master
5aacee4 
Website Revamp. Improved a lot.
SaptarshiSarkar12 added a commit that referenced this pull request Jul 7, 2023
@SaptarshiSarkar12
Merge pull request #54 from aryan-upa/master
4fe9098 
Website Revamp. Improved a lot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaptarshiSarkar12 SaptarshiSarkar12 SaptarshiSarkar12 approved these changes

Assignees
No one assigned
Labels
feature ✨ New feature request or addition hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest Website 🌐 Issues/Pull Requests regarding Website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Change the look and feel of website
2 participants
@aryan-upa @SaptarshiSarkar12