Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Github stars and forks count in website. closes issue #82 #163

Merged
merged 10 commits into from
Oct 27, 2022
Merged

Added Github stars and forks count in website. closes issue #82 #163

merged 10 commits into from
Oct 27, 2022

Conversation

Akshatjaiswal5
Copy link
Contributor

Please link this pr to issue #82 if not already.
Added stars and fork count, other changes are due to my formatter.
Please review and merge these changes before 30oct, I want them counted in Hacktoberfest.
Thank you.

@netlify
Copy link

netlify bot commented Oct 25, 2022 •
edited
Loading

✅ Deploy Preview for drifty ready!

Name Link
🔨 Latest commit 5969ddb
🔍 Latest deploy log https://app.netlify.com/sites/drifty/deploys/635a11414480300009364ad2
😎 Deploy Preview https://deploy-preview-163--drifty.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@SaptarshiSarkar12 SaptarshiSarkar12 linked an issue Oct 25, 2022 that may be closed by this pull request
[FEATURE] Add Stars And Forks in the footer of the website #82
Closed
@SaptarshiSarkar12
Copy link
Owner

@Akshatjaiswal5 Please keep the stars and forks in the more info section below the text and beside contribute to drifty button.
image

@SaptarshiSarkar12
Copy link
Owner

@Akshatjaiswal5 Please keep the stars and forks in the more info section below the text and beside contribute to drifty button. image

@Akshatjaiswal5 please make the changes.

@Akshatjaiswal5
Copy link
Contributor Author

@Akshatjaiswal5 Please keep the stars and forks in the more info section below the text and beside contribute to drifty button. image

@Akshatjaiswal5 please make the changes.

Done

@SaptarshiSarkar12
Copy link
Owner

@Akshatjaiswal5 Please fix this for mobiles. The buttons moved out of the screen width.
Screenshot_2022-10-26-17-09-20

@Akshatjaiswal5
Copy link
Contributor Author

Please check it now

@SaptarshiSarkar12
Copy link
Owner

Please check it now

Please add link to stargazers and forks link to the respective buttons.
@Akshatjaiswal5

@Akshatjaiswal5
Copy link
Contributor Author

Please check it now

Please add link to stargazers and forks link to the respective buttons. @Akshatjaiswal5

Done

@SaptarshiSarkar12
Copy link
Owner

@Akshatjaiswal5 please resolve the conflicts. Then, i shall merge this PR.

@Akshatjaiswal5
Copy link
Contributor Author

@Akshatjaiswal5 please resolve the conflicts. Then, i shall merge this PR.

Done

@SaptarshiSarkar12
Copy link
Owner

@Akshatjaiswal5 please resolve the conflicts. Then, i shall merge this PR.

Done

Great ! @Akshatjaiswal5

@SaptarshiSarkar12 SaptarshiSarkar12 self-requested a review October 27, 2022 07:36
SaptarshiSarkar12
SaptarshiSarkar12 approved these changes Oct 27, 2022
View reviewed changes
Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Thanks for contributing 🚀 🚀
@Akshatjaiswal5 Please leave a star ⭐ on this project if you liked contributing to it. You may join my Discord server for the project's Discussions - https://discord.gg/DeT4jXPfkG

@SaptarshiSarkar12 SaptarshiSarkar12 merged commit 68df2a9 into SaptarshiSarkar12:master Oct 27, 2022
@SaptarshiSarkar12 SaptarshiSarkar12 added the hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest label Oct 27, 2022
@SaptarshiSarkar12 SaptarshiSarkar12 added feature ✨ New feature request or addition Website 🌐 Issues/Pull Requests regarding Website labels Mar 20, 2023
SaptarshiSarkar12 added a commit that referenced this pull request Jul 6, 2023
@SaptarshiSarkar12
Merge pull request #163 from Akshatjaiswal5/master
831dc2e 
Added Github stars and forks count in website. closes issue #82
SaptarshiSarkar12 added a commit that referenced this pull request Jul 7, 2023
@SaptarshiSarkar12
Merge pull request #163 from Akshatjaiswal5/master
dc6fc22 
Added Github stars and forks count in website. closes issue #82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaptarshiSarkar12 SaptarshiSarkar12 SaptarshiSarkar12 approved these changes

Assignees
No one assigned
Labels
feature ✨ New feature request or addition hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest Website 🌐 Issues/Pull Requests regarding Website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Stars And Forks in the footer of the website
2 participants
@Akshatjaiswal5 @SaptarshiSarkar12