Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made demo video responsive #157

Merged
merged 7 commits into from
Oct 28, 2022

Conversation

Krishnansh5
Copy link
Contributor

  • Made demo video fit into screen and responsive.
  • Also added link to demo section in navbar

@netlify
Copy link

netlify bot commented Oct 24, 2022

Deploy Preview for drifty ready!

Name Link
🔨 Latest commit 2e22920
🔍 Latest deploy log https://app.netlify.com/sites/drifty/deploys/635b806207a7170008094d3b
😎 Deploy Preview https://deploy-preview-157--drifty.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Krishnansh5
Copy link
Contributor Author

This solves issue #151

@SaptarshiSarkar12 SaptarshiSarkar12 linked an issue Oct 24, 2022 that may be closed by this pull request
@SaptarshiSarkar12
Copy link
Owner

@Krishnansh5 the video goes out of the screen width of mobiles. Please fix it.
Screenshot_2022-10-24-19-23-09

@Krishnansh5
Copy link
Contributor Author

@SaptarshiSarkar12 Fixed the issue

@SaptarshiSarkar12
Copy link
Owner

@Krishnansh5 the nav bar overlaps the text in the home part.
Screenshot_2022-10-25-08-25-15

@Krishnansh5
Copy link
Contributor Author

  • changed the height of header component to fit-content otherwise the content was overflowing for smaller screens anyways and this doesn't make a lot of difference in positioning of the content. It looked good to me on mobile as well.

@SaptarshiSarkar12
Copy link
Owner

  • changed the height of header component to fit-content otherwise the content was overflowing for smaller screens anyways and this doesn't make a lot of difference in positioning of the content. It looked good to me on mobile as well.

Shall check and inform you @Krishnansh5 .

@SaptarshiSarkar12 SaptarshiSarkar12 self-requested a review October 27, 2022 03:13
Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Thanks for contributing 🚀 🚀.
@Krishnansh5 Please leave a star ⭐ on this project if you liked contributing to it. You may join our discord server : https://discord.gg/DeT4jXPfkG

@SaptarshiSarkar12 SaptarshiSarkar12 merged commit eb04746 into SaptarshiSarkar12:master Oct 28, 2022
@SaptarshiSarkar12 SaptarshiSarkar12 added the hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest label Oct 28, 2022
@SaptarshiSarkar12 SaptarshiSarkar12 added bug 🐛 Issues/Pull Requests reporting/fixing a bug Website 🌐 Issues/Pull Requests regarding Website labels Mar 20, 2023
SaptarshiSarkar12 added a commit that referenced this pull request Jul 6, 2023
made demo video responsive
SaptarshiSarkar12 added a commit that referenced this pull request Jul 7, 2023
made demo video responsive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issues/Pull Requests reporting/fixing a bug hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest Website 🌐 Issues/Pull Requests regarding Website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Make demonstration video size adjust in the screen
2 participants