Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto-detect downloads folder broken for linux #112

Merged
merged 13 commits into from
Oct 11, 2022
Merged

auto-detect downloads folder broken for linux #112

merged 13 commits into from
Oct 11, 2022

Conversation

poshi1865
Copy link
Contributor

@poshi1865 poshi1865 commented Oct 11, 2022 •
edited
Loading

#111 Checked whether OS is windows or not, and gave paths accordingly. Please review and let me know.

@netlify
Copy link

netlify bot commented Oct 11, 2022 •
edited
Loading

✅ Deploy Preview for drifty ready!

Name Link
🔨 Latest commit 8b8facf
🔍 Latest deploy log https://app.netlify.com/sites/drifty/deploys/6345696274442d0008bf8427
😎 Deploy Preview https://deploy-preview-112--drifty.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@poshi1865
Copy link
Contributor Author

Oh sorry, I think this pr contains my commits done in the previous fix, let me work on fixing #1 first, and then this will become mergeable as well.

@SaptarshiSarkar12
Copy link
Owner

Oh sorry, I think this pr contains my commits done in the previous fix, let me work on fixing #1 first, and then this will become mergeable as well.

Ok @poshi1865

@SaptarshiSarkar12 SaptarshiSarkar12 linked an issue Oct 11, 2022 that may be closed by this pull request
[BUG] Automatic detection of downloads folder broken for unix based operating systems #111
Closed
@SaptarshiSarkar12 SaptarshiSarkar12 self-requested a review October 11, 2022 10:31
@poshi1865
Copy link
Contributor Author

I think this is now mergeable too @SaptarshiSarkar12

@poshi1865
Copy link
Contributor Author

the conflicting file is a .class file, and it is showing that I cannot resolve the conflict, only people with write access can

@SaptarshiSarkar12
Copy link
Owner

the conflicting file is a .class file, and it is showing that I cannot resolve the conflict, only people with write access can

ok @poshi1865 , I have fixed it.

@SaptarshiSarkar12
Copy link
Owner

Sorry @poshi1865 , closed it by mistake

@poshi1865
Copy link
Contributor Author

Sorry @poshi1865 , closed it by mistake

No worries :)

SaptarshiSarkar12
SaptarshiSarkar12 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Thanks for contributing 🚀🚀.

@SaptarshiSarkar12 SaptarshiSarkar12 merged commit 4ccb2ca into SaptarshiSarkar12:master Oct 11, 2022
@poshi1865 poshi1865 deleted the bug-auto-download-broken-111 branch October 11, 2022 13:25
@SaptarshiSarkar12 SaptarshiSarkar12 added the hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest label Oct 11, 2022
@SaptarshiSarkar12 SaptarshiSarkar12 changed the title Bug auto download broken 111 auto-detect downloads folder broken for linux Mar 20, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 added bug 🐛 Issues/Pull Requests reporting/fixing a bug App 💻 Issues/Pull Requests which update Drifty Application Code labels Mar 20, 2023
SaptarshiSarkar12 added a commit that referenced this pull request Jul 6, 2023
@SaptarshiSarkar12
Merge pull request #112 from poshi1865/bug-auto-download-broken-111
072b25c 
Bug auto download broken #111
SaptarshiSarkar12 added a commit that referenced this pull request Jul 7, 2023
@SaptarshiSarkar12
Merge pull request #112 from poshi1865/bug-auto-download-broken-111
96bb016 
Bug auto download broken #111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaptarshiSarkar12 SaptarshiSarkar12 SaptarshiSarkar12 approved these changes

Assignees
No one assigned
Labels
App 💻 Issues/Pull Requests which update Drifty Application Code bug 🐛 Issues/Pull Requests reporting/fixing a bug hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Automatic detection of downloads folder broken for unix based operating systems
2 participants
@poshi1865 @SaptarshiSarkar12