Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Hide pre-releases if latest version released succeeds the pre-release version #670

Closed
SaptarshiSarkar12 opened this issue Oct 4, 2024 · 3 comments · Fixed by #671
Closed

[BUG] Hide pre-releases if latest version released succeeds the pre-release version #670

SaptarshiSarkar12 opened this issue Oct 4, 2024 · 3 comments · Fixed by #671
Assignees
@aaronrojas32
Labels
bug 🐛 Issues/Pull Requests reporting/fixing a bug EddieHub:good-first-issue Label for good-first-issue finder made by EddieHub Community good first issue Good for newcomers hacktoberfest Issues/Pull Requests for Hacktoberfest Website 🌐 Issues/Pull Requests regarding Website
Milestone
Drifty v2.2.0

Comments

@SaptarshiSarkar12
Copy link
Owner

Describe the bug

Currently, the Website shows the pre-release version (v2.1.0-rc.1) even after v2.1.0 has been released.

Steps To Reproduce

  1. Go to the official website.
  2. Click on Download.
  3. You can see that the latest version is v2.1.0 but the Release Candidate release of v2.1.0-rc.1 is still shown.

Expected Behavior

Any pre-release must not be shown if there is a stable release already made after the pre-release had been released.
Here are some examples 👇

  • stable: v2.0.0 , pre-release: v2.1.0-beta.1 => pre-release shown ✅
  • stable: v2.1.0 , pre-release: v2.1.0-beta.1 => pre-release shown ❌

Operating System

Windows 🪟, MacOS 🍏, Linux 🐧, Other

Browser

Microsoft Edge, Google Chrome, Safari, Brave, Other

Screenshots

screen-20241004-120312.mp4

Additional information

If anyone wants to work on this issue, please comment down below.

Do you want to work on this issue?

No
@SaptarshiSarkar12 SaptarshiSarkar12 added bug 🐛 Issues/Pull Requests reporting/fixing a bug good first issue Good for newcomers hacktoberfest Issues/Pull Requests for Hacktoberfest EddieHub:good-first-issue Label for good-first-issue finder made by EddieHub Community Website 🌐 Issues/Pull Requests regarding Website labels Oct 4, 2024
@SaptarshiSarkar12 SaptarshiSarkar12 added this to the Drifty v2.2.0 milestone Oct 4, 2024
@github-project-automation github-project-automation bot moved this to Todo in Drifty Oct 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Hello 👋! Thank you very much for raising an issue 🙌! The maintainers will get back to you soon for discussion over the issue! 🚀

Meanwhile you can also discuss about the project in our Discord Server 😀

@aaronrojas32
Copy link
Contributor

Hey, I would like to work on it, can u asing me this issue?

@SaptarshiSarkar12
Copy link
Owner Author

@aaronrojas32 Hi Aaron 👋!
Thank you for your interest in the issue 😁!
Assigning this task to you 😃.

@aaronrojas32 aaronrojas32 mentioned this issue Oct 4, 2024
Merged
5 tasks
@SaptarshiSarkar12 SaptarshiSarkar12 moved this from Todo to In Progress in Drifty Oct 4, 2024
SaptarshiSarkar12 pushed a commit that referenced this issue Oct 4, 2024
@aaronrojas32 @coderabbitai
Fix: Enhanced Filtering for Pre-releases (#671)
cc86692 
* Fixed the issue #670

Fixed issue where pre-release versions (e.g., v2.1.0-rc.1) were shown even after the stable version (v2.1.0) was released.

- Added logic to filter out pre-releases if a stable version with the same base version (e.g., v2.1.0) exists.
- Extracted base version from the release tag using split('-')[0] to compare stable and pre-release versions.
- Ensured only one pre-release is shown when no corresponding stable release exists.

* Update Website/app/Releases.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update Website/app/Releases.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Drifty Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronrojas32 aaronrojas32

Labels
bug 🐛 Issues/Pull Requests reporting/fixing a bug EddieHub:good-first-issue Label for good-first-issue finder made by EddieHub Community good first issue Good for newcomers hacktoberfest Issues/Pull Requests for Hacktoberfest Website 🌐 Issues/Pull Requests regarding Website
Projects
Drifty
Status: Done
Milestone
Drifty v2.2.0
Development

Successfully merging a pull request may close this issue.

Fix: Enhanced Filtering for Pre-releases aaronrojas32/Drifty
2 participants
@aaronrojas32 @SaptarshiSarkar12