Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Add support for updating yt-dlp #215

Closed
SaptarshiSarkar12 opened this issue Jun 24, 2023 · 10 comments · Fixed by #222
Closed

[BUG] Add support for updating yt-dlp #215

SaptarshiSarkar12 opened this issue Jun 24, 2023 · 10 comments · Fixed by #222
Assignees
@SaptarshiSarkar12
Labels
App 💻 Issues/Pull Requests which update Drifty Application Code bug 🐛 Issues/Pull Requests reporting/fixing a bug EddieHub:good-first-issue Label for good-first-issue finder made by EddieHub Community good first issue Good for newcomers
Milestone
Drifty v2.0.0

Comments

@SaptarshiSarkar12
Copy link
Owner

SaptarshiSarkar12 commented Jun 24, 2023 •
edited
Loading

Describe the bug

The Drifty executables released, contains yt-dlp (the program responsible for downloading YouTube videos) inside them. Whenever the user tries to download YouTube videos, Drifty passes the YouTube video link to yt-dlp which then downloads it. If yt-dlp is not on the latest version, it throws an error (shown in the image below 👇).

Screenshots

Yt-dlp Error

Additional information

If the yt-dlp update command (yt-dlp -U) is run to update itself before initiating the download process, the error might be avoided.
Check out yt-dlp GitHub repository to learn more about it.
@SaptarshiSarkar12 SaptarshiSarkar12 converted this from a draft issue Jun 24, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 added bug 🐛 Issues/Pull Requests reporting/fixing a bug help wanted Extra attention and support, and contributors are needed good first issue Good for newcomers EddieHub:good-first-issue Label for good-first-issue finder made by EddieHub Community App 💻 Issues/Pull Requests which update Drifty Application Code labels Jun 24, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 changed the title Add support for updating yt-dlp [BUG] Add support for updating yt-dlp Jun 24, 2023
@SaptarshiSarkar12
Copy link
Owner Author

If anyone wants to work on this issue, please comment your name here and I shall assign you.

@pushkaraj2007
Copy link

Hey @SaptarshiSarkar12

Can you please explain a bit more about this issue?

@SaptarshiSarkar12
Copy link
Owner Author

Hey @SaptarshiSarkar12

Can you please explain a bit more about this issue?

@pushkaraj2007 Yeah, sure. The Drifty executables released, contains yt-dlp (the program responsible for downloading YouTube videos) inside them. Whenever the user tries to download YouTube videos, Drifty passes the YouTube video link to yt-dlp which then downloads it. If yt-dlp is not on the latest version, it throws an error (shown in the image below 👇).

Yt-dlp Error

This error can be solved by passing the -U flag to yt-dlp to update itself before downloading the YouTube video. Hence, no error will henceforth be thrown.

You can check out yt-dlp project to learn more about it.

@pushkaraj2007
Copy link

@SaptarshiSarkar12

Thanks!

So, what needs to be fix to solve this issue?

@SaptarshiSarkar12
Copy link
Owner Author

@SaptarshiSarkar12

Thanks!

So, what needs to be fix to solve this issue?

@pushkaraj2007 Whenever the user provides a YouTube video link to Drifty, Drifty should check and update yt-dlp (if it's not on the latest version) before initiating the download process. The command to update yt-dlp is yt-dlp -U. You also need to check if that work or not.

@SaptarshiSarkar12
Copy link
Owner Author

@pushkaraj2007 Do you want to work on this issue?

@SaptarshiSarkar12
Copy link
Owner Author

@pushkaraj2007 Do you want to work on this issue?

@pushkaraj2007 Please respond.

@pushkaraj2007
Copy link

@pushkaraj2007 Do you want to work on this issue?

@pushkaraj2007 Please respond.

@SaptarshiSarkar12

I would like to, but TBH I don't have much experience with using Java.

I noticed this after asking you the question that Java is being used in this project.

@SaptarshiSarkar12
Copy link
Owner Author

@pushkaraj2007 Do you want to work on this issue?

@pushkaraj2007 Please respond.

@SaptarshiSarkar12

I would like to, but TBH I don't have much experience with using Java.

I noticed this after asking you the question that Java is being used in this project.

Ok @pushkaraj2007 . If you want, you may try this out.

@SaptarshiSarkar12
Copy link
Owner Author

I shall work on this issue as no one is interested to work on this.

@SaptarshiSarkar12 SaptarshiSarkar12 self-assigned this Jul 7, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 linked a pull request Jul 7, 2023 that will close this issue
Added support for updating yt-dlp if it is outdated #222
Merged
5 tasks
@SaptarshiSarkar12 SaptarshiSarkar12 mentioned this issue Jul 7, 2023
Merged
5 tasks
SaptarshiSarkar12 added a commit that referenced this issue Jul 7, 2023
@SaptarshiSarkar12
Added support for updating yt-dlp if it is outdated (PR #222)
7831f8b 
Added support for updating yt-dlp via PR #222 fixing #215 by @SaptarshiSarkar12
---
* Fix(App): Added support for updating yt-dlp if it is outdated

* Fix(App): Removed unnecessary lines

* chore: Updated Drifty.icns file

* feat: Added more log lines
@github-project-automation github-project-automation bot moved this from Todo to Done in Drifty Jul 7, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 removed the help wanted Extra attention and support, and contributors are needed label Jul 17, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 added this to the Drifty v2.0.0 milestone Aug 10, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 modified the milestone: Drifty v2.0.0 Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaptarshiSarkar12 SaptarshiSarkar12

Labels
App 💻 Issues/Pull Requests which update Drifty Application Code bug 🐛 Issues/Pull Requests reporting/fixing a bug EddieHub:good-first-issue Label for good-first-issue finder made by EddieHub Community good first issue Good for newcomers
Projects
Drifty
Status: Done
Milestone
Drifty v2.0.0
Development

Successfully merging a pull request may close this issue.

Added support for updating yt-dlp if it is outdated SaptarshiSarkar12/Drifty
2 participants
@SaptarshiSarkar12 @pushkaraj2007