Fix C++ API observers with sparse components by filling out iterator field flags in flecs_uni_observer_invoke #1299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed C++ observers with sparse components cause this assert to fire:
fatal: flecs.c: 10947: assert: !(idr->flags & EcsIdIsSparse) use ecs_field_at to access fields for sparse components (INVALID_OPERATION)
A simple repro:
After some messing around I found that
each_delegate::invoke(ecs_iter_t *iter)
seems to expectref_fields
to be set to determine if it usesterms.populate
rather thanterms.populate_self
. I am not sure if this is the correct fix as this is the first time I've really done anything in flecs internals.I think it would be useful to run the test cases with different combinations of sparse and non-sparse components to catch things like this ahead of time for commonly used API things.