Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Iot Headed/Headless API ref #1358

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

sgchoi5
Copy link
Contributor

@sgchoi5 sgchoi5 commented Nov 24, 2020

  • Target: 4.0 / 5.0 / 5.5
  • Removed unnecessary modules
  • Fixed some minor issues (broken link, etc)

@TizenDocsBot
Copy link
Collaborator

checkout the webpage https://docs1.stg.tizen.org/staging/1358

@TizenDocsBot
Copy link
Collaborator

Check Broken Link: Not found any broken link

Copy link
Contributor

@mijin85cho mijin85cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello.

I skimmed the pages and got below queries.

Also, I reported an issue with the updated pages.

With the updated files, the LNB works.
However, in some pages, the layout is dragged down to the end of LNB, so at first sight the page shows just a blank window.

image

After scrolling :
image

I reported this issue to https://github.sec.samsung.net/RS8-TIZENWEBSITE/docs.tizen.org/issues/430.
Would you also please check the issue page to get the status?

ftd = calloc(1, <span class="keyword">sizeof</span>(Feedback_Thread_Data));
ftd-&gt;name = strdup(<span class="stringliteral">&quot;data0&quot;</span>);
ftd-&gt;base = strdup(<span class="stringliteral">&quot;/usr/bin&quot;</span>);
<a name="a44"></a><a class="code" href="group__Eina__Lock__Group.html#ga8dda398c1db315582a80640c7f78f648" title="Initializes a new #Eina_Lock.">eina_lock_new</a>(&amp;ftd-&gt;mutex);
eina_lock_new(&amp;ftd-&gt;mutex);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems eina_lock_new() is removed. Can it be remained here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think .. new version is correct, because previous 4.0 headed api ref was made by very old header files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is same in https://docs1.stg.tizen.org/staging/1358/application/native/api/iot-headed/6.0/ecore_thread_example_8c-example.html, so I asked.

image

However if you think this issue is not critical, I'll just merge this PR after we get the reply for the dragged window issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of EFL, I will try to fix issues in this page.
https://code.sec.samsung.net/confluence/pages/viewpage.action?pageId=194846376

Hard to fix it quickly, because EFL team needs to fix upstream header first and sync it to Tizen Platform and SR should be completed. It takes ... at least 2~3 weeks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, correct. I am trying to fix them all.. t.t
Yesterday, I sent all issues to developers. waiting for fix and feedback..


<a name="a50"></a><a class="code" href="group__Eina__Lock__Group.html#ga838e1e7dfc8bbf114634a7de67de8956" title="Deallocates a condition variable.">eina_condition_free</a>(&amp;appdata.condition);
<a class="code" href="group__Eina__Lock__Group.html#gaf8d1c4e3aff3bd26fc85d81ed8c4e71a" title="Deallocates an #Eina_Lock.">eina_lock_free</a>(&amp;appdata.mutex);
eina_condition_free(&amp;appdata.condition);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems eina_condition_free() is removed. Can it be remained here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think .. new version is correct, because previous 4.0 headed api ref was made by very old header files.

@@ -214,9 +214,9 @@
<span class="keywordflow">while</span> (1)
{
<span class="keywordtype">int</span> msgs;
<a class="code" href="group__Eina__Lock__Group.html#ga149f387d5f18c469c365147ffbd4dc2c" title="Causes a thread to wait until signaled by the condition.">eina_condition_wait</a>(&amp;ad-&gt;condition);
eina_condition_wait(&amp;ad-&gt;condition);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems eina_condition_wait() is removed. Can it be remained here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think .. new version is correct, because previous 4.0 headed api ref was made by very old header files.

@@ -81,7 +81,7 @@
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this page, there are broken tables. Would you please check?

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DALi is deprecated. They have stopped the maintenance of DALi...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question. The issue I reported about the window display is happening in DALi.

If DALi is deprecated, can we just ignore that issue on https://github.sec.samsung.net/RS8-TIZENWEBSITE/docs.tizen.org/issues/430?

In other pages I couldn't find the same issue yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think.. if it is not critical issue, hard to fix DALi issues... : (

@@ -106,7 +106,7 @@ <h2><a class="anchor" id="NATIVE_API_REFERENCE_SECTION1"></a>
</p>
<h2><a class="anchor" id="NATIVE_API_REFERENCE_SECTION2"></a>
Related Feature</h2>
<p>Some of the Tizen native APIs require features to prevent your application from being shown in the application list on the Tizen store. If related Feature is included in API reference as shown below and your application uses that feature, then you need to declare the feature in the tizen-manifest.xml file. For more information, see <a href="https://developer.tizen.org/development/getting-started/native-application/understanding-tizen-programming/application-filtering"><b>Application Filtering</b>.</a> </p>
<p>Some of the Tizen native APIs require features to prevent your application from being shown in the application list on the Tizen store. If related Feature is included in API reference as shown below and your application uses that feature, then you need to declare the feature in the tizen-manifest.xml file. For more information, see <a href="https://docs.tizen.org/application/native/tutorials/details/app-filtering"><b>Application Filtering</b>.</a> </p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question.

IoT Headed / Headless API are based on Tizen Native API. Is it the reason of keep using the "Tizen native API" in the pages?

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iot Profiles support Native API. but, different coverage compared with Mobile / Wearable.

@mijin85cho
Copy link
Contributor

@sgchoi5 I found some issues within this PR,
however most of them are same with the current published version, or not critical, or will take some time to fix (or hard to fix).

So, I'd like to merge this PR for now.
If so, about weeks later you can create a new PR for new version that will be generated at that time. Will you?

@sgchoi5
Copy link
Contributor Author

sgchoi5 commented Nov 27, 2020

Yes, I will try. but, not easy to fix issues, because developers must update their header files.

@@ -98,13 +98,17 @@
<tr><td colspan="2"><h2><a name="func-members"></a>
Functions</h2></td></tr>
<tr><td class="memItemLeft" align="right" valign="top">int&#160;</td><td class="memItemRight" valign="bottom"><a class="el" href="group__Evas__Main__Group.html#ga65b3f060b6dd9e488afd0b8cbe101869">evas_init</a> (void)</td></tr>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check the function 'evas_init (void)' compared to mobile API Reference.
(ref. https://docs.tizen.org/application/native/api/mobile/6.0/group__Evas__Main__Group.html : EINA_DEPRECATED int)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is wrong deprecated TAG. I've added an issue to https://code.sec.samsung.net/confluence/pages/viewpage.action?pageId=194846376
Issue No. 60

EFL part need to update header file.... Can't fix it right now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I got it.

@@ -114,7 +114,7 @@ <h2><a class="anchor" id="CAPI_OAUTH2_MODULE_FEATURE"></a>
</p>
<p>To ensure your application is only running on the device with specific features, please define the features in your manifest file using the manifest editor in the SDK.<br/>
</p>
<p>More details on featuring your application can be found from <a href="https://developer.tizen.org/development/tizen-studio/native-tools/configuring-your-app/manifest-text-editor#feature"><b>Feature List</b>.</a>a&gt;</p>
<p>More details on featuring your application can be found from <a href="https://docs.tizen.org/application/tizen-studio/native-tools/manifest-text-editor#feature-element"><b>Feature List</b>.</a>a&gt;</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you delete a&gt; after <b>Feature List</b>.</a>?
The 6.0 version also has the same content, please modify it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oauth2_doc.h should be fixed to remove unnecessary a>
I've added it to issue page with No.59.

In this case, I've fixed html directly and pushed changes.

@@ -90,7 +90,7 @@
<a href="#func-members">Functions</a> </div>
<div class="headertitle">
<div class="title">AT-SPI2 Accessibility</div> </div>
<div class="ingroups"><a class="el" href="group__Elm__Engine.html">Elementary Engine</a> &#124; <a class="el" href="group__elm__infra__group.html">Elementary Infrastructure</a></div></div><!--header-->
<div class="ingroups"><a class="el" href="group__Elm__Engine.html">Elementary Engine</a> &#124; <a class="el" href="group__Elementary.html">Elementary</a></div></div><!--header-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the Menu tree and confirm exact location.
The 6.0 version also has the same issue, please modify it.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mijin80lee
Copy link
Contributor

Could you change URLs of 'Feature Element' of following pages as below?
(Tizen Docs, https://docs.tizen.org/application/tizen-studio/native-tools/manifest-text-editor#feature-element)

docs/application/native/api/iot-headed/6.0/group__CAPI__SYSTEM__PERIPHERAL__IO__ADC__MODULE.html
docs/application/native/api/iot-headed/6.0/group__CAPI__SYSTEM__PERIPHERAL__IO__GPIO__MODULE.html
docs/application/native/api/iot-headed/6.0/group__CAPI__SYSTEM__PERIPHERAL__IO__I2C__MODULE.html
docs/application/native/api/iot-headed/6.0/group__CAPI__SYSTEM__PERIPHERAL__IO__PWM__MODULE.html
docs/application/native/api/iot-headed/6.0/group__CAPI__SYSTEM__PERIPHERAL__IO__SPI__MODULE.html
docs/application/native/api/iot-headed/6.0/group__CAPI__SYSTEM__PERIPHERAL__IO__UART__MODULE.html
docs/application/native/api/iot-headed/6.0/group__CAPI__SYSTEM__UPDATE__CONTROL__MODULE.html

@mijin80lee
Copy link
Contributor

Could you add '(Deprecated)' to the title on DALi Toolkit page?
docs/application/native/api/iot-headed/6.0/group__dali__toolkit.html

image

- Target: 4.0 / 5.0 / 5.5
- Removed unnecessary modules
- Fixed some minor issues (broken link, etc)
@TizenDocsBot
Copy link
Collaborator

checkout the webpage https://docs1.stg.tizen.org/staging/1358

@TizenDocsBot
Copy link
Collaborator

Check Broken Link: Not found any broken link

@sgchoi5
Copy link
Contributor Author

sgchoi5 commented Nov 30, 2020

Could you add '(Deprecated)' to the title on DALi Toolkit page?
docs/application/native/api/iot-headed/6.0/group__dali__toolkit.html

image

will be fixed with next update. Recently, Dali team fixed it.

@sgchoi5
Copy link
Contributor Author

sgchoi5 commented Dec 1, 2020

Copy link
Contributor

@mijin85cho mijin85cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending issues will be checked with next version.

@mijin85cho mijin85cho merged commit 5477451 into Samsung:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants