Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Skia version to remove vulnerability #24

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

JoonghyunCho
Copy link
Member

This PR updates following Skia version to remove security vulnerability.

  <ItemGroup>
    <PackageReference Include="Microsoft.Maui.Graphics" Version="$(MicrosoftMauiGraphicsVersion)" />
    <PackageReference Include="Microsoft.Maui.Graphics.Skia" Version="$(MicrosoftMauiGraphicsVersion)" />
  </ItemGroup>

Background

(dotnet/maui#17558)
About 3 weeks ago, security vulnerability is detected for SkiaSharp.Views and any project referencing this package is warned for the security vulnerability.
The vulnerability is patched in SkiaSharp v2.88.6 and Microsoft.Maui.Graphics is now released with it on v8.0.0-rc.2.9373.

What to do next?

  • Release Tizen.UIExtensions (eg. v0.9.1)
  • Update Tizen.UIExtensions on MAUI.
  • Remove SkiaSharp.Views direct reference from CommunityToolkit.Maui which was the workaround for Tizen.

rookiejava
rookiejava previously approved these changes Oct 11, 2023
Copy link
Contributor

@rookiejava rookiejava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could you also look into failed reated to build action?

@JoonghyunCho
Copy link
Member Author

@rookiejava Absolutely! Issue is fixed on #25.
I will rebase the PR when it is merged.

@rookiejava
Copy link
Contributor

@rookiejava Absolutely! Issue is fixed on #25. I will rebase the PR when it is merged.

#25 has been merged.

sung-su
sung-su previously approved these changes Oct 12, 2023
@JoonghyunCho JoonghyunCho dismissed stale reviews from sung-su and rookiejava via 6820985 October 13, 2023 04:17
@JoonghyunCho
Copy link
Member Author

SkiaSharp.Views direct reference is added because net6.0 Microsoft.Maui.Graphics is not released anymore.

@rookiejava rookiejava merged commit b6f0f62 into Samsung:main Oct 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants