GridView: Fit image to grid item without crop #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomaszLukawskiSam
force-pushed
the
issue-change-image-size-in-gridview
branch
3 times, most recently
from
d997b7c
to
8bd9374
Compare
singa2000
reviewed
Oct 12, 2021
| @@ -164,6 +164,18 @@ tau-gridview { | |||
| } | |||
| } | |||
|
|
|||
| &.ui-gridview-image-icon .ui-gridview-item img, | |||
There was a problem hiding this comment.
If the girdview image is mixed with general image and icon
and I don't know which image will be on the grid , how about it?
I think in that case I can't use the "ui-gridview-image-icon".
Signed-off-by: Tomasz Lukawski <[email protected]>
TomaszLukawskiSam
force-pushed
the
issue-change-image-size-in-gridview
branch
from
8bd9374
to
27cb01e
Compare
Signed-off-by: Tomasz Lukawski <[email protected]>
Signed-off-by: Tomasz Lukawski <[email protected]>
Signed-off-by: Tomasz Lukawski <[email protected]>
TomaszLukawskiSam
force-pushed
the
issue-change-image-size-in-gridview
branch
from
5a69f6b
to
81c8483
Compare
TomaszLukawskiSam
force-pushed
the
issue-change-image-size-in-gridview
branch
2 times, most recently
from
b7a3fff
to
e6708a9
Compare
Signed-off-by: Tomasz Lukawski <[email protected]>
TomaszLukawskiSam
force-pushed
the
issue-change-image-size-in-gridview
branch
from
e6708a9
to
c2c6f4c
Compare
singa2000
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New css class has been added to Gridview widget
The
ui-gridview-image-iconfits image size to the grid item container.The GridView widget detects icons and adds
ui-gridview-image-iconto image.Signed-off-by: Tomasz Lukawski [email protected]