Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to double-quoted string #78

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

alexanderfrodeberg
Copy link
Contributor

With single quotes ('\n'), the str_replace() function won't recognize it as a newline character. It will look for the literal sequence of a backslash followed by n, which I don't think we want.

With single quotes ('\n'), the str_replace() function won't recognize it as a newline character. It will look for the literal sequence of a backslash followed by n, which I don't think we want.
@alexanderfrodeberg alexanderfrodeberg changed the title Change to double-quoted strings Change to double-quoted string Jan 15, 2024
Copy link
Owner

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good spot, thank you for fixing this!

@alexanderfrodeberg
Copy link
Contributor Author

When could this be merged? 🙂 @Sammyjo20

@Sammyjo20
Copy link
Owner

Sorry about the delay!

@Sammyjo20 Sammyjo20 merged commit e11942a into Sammyjo20:v3.0 Jan 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants