[K12] Add task to K12 yml to support New Picklists Value for Citizenship Status on Contact #296
Conversation
…hed__Citizenship_Status_c on Contact
kdy618
changed the title
Co-authored-by: Matthew Blanski <[email protected]>
Co-authored-by: Matthew Blanski <[email protected]>
There was a problem hiding this comment.
Tentatively approved. This functioned when I changed over to the eda beta, which has the citizenship picklist task. We will need to wait until the release merge (which is appropriate) until we merge this in.
@spinkelman FYI
@jofsky FYI
|
@kdy618 I've discussed my idea of having an upstream EDA configuration task to be passed downstream to allow all the products to reduce code duplication. I'll approve this for now but lets make this part of our larger effort to reduce this code footprint. |
There was a problem hiding this comment.
@kdy618 I've discussed my idea of having an upstream EDA configuration task to be passed downstream to allow all the products to reduce code duplication. I'll approve this for now but lets make this part of our larger effort to reduce this code footprint.
|
@MatthewBlanski @jofsky , I had to fix merge conflict. If you don't mind re-reviewing this PR. Thank you in advance. |
|
@kdy618 what's the status of this? |
|
@jofsky, I initially was waiting for approval and based on Matt's initial response #296 (review) as to why this PR was not merged. I had to fix merge conflict when the cumulus file was updated and resubmitted for approval. It looks like @MatthewBlanski approved it and was waiting for your approval. However, it looks like it hit another merged conflict. Is there a better way for me to get this PR closed? |
|
@jofsky @MatthewBlanski , fixed the linter :D |
|
QA Passes - Ran trial > trial_org - Verified picklist values appear in org and no error on task run in cci. |
Critical Changes
Changes
Added a new task to K12 cumulus.yml file to reference an EDA task that adds new picklist value for hed__Citizenship_Status__c on Contact.
Issues Closed
Close #295
New Metadata
Unpackaged Metadata
Deleted Metadata
Testing Notes