Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add application type picklist values #220

Merged
merged 19 commits into from
Aug 5, 2020

Conversation

jofsky
Copy link
Contributor

@jofsky jofsky commented May 28, 2020

Critical Changes

Changes

Issues Closed

New Metadata

Deleted Metadata

Testing Notes

@jofsky jofsky requested a review from a team as a code owner May 28, 2020 22:52
jstvz
jstvz previously approved these changes May 28, 2020
MatthewBlanski
MatthewBlanski previously approved these changes May 29, 2020
Copy link
Contributor

@MatthewBlanski MatthewBlanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are functional.

@jofsky jofsky dismissed stale reviews from MatthewBlanski and jstvz via b577658 June 9, 2020 03:05
@jstvz
Copy link
Member

jstvz commented Jun 30, 2020

@jofsky What's the status of this PR? Can you update the title/description?

@spinkelman spinkelman self-requested a review July 29, 2020 21:33
Copy link
Member

@jstvz jstvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Looks like there are some test failures on master blocking merge.

Copy link
Contributor

@spinkelman spinkelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes QA - Will Merge

@spinkelman spinkelman merged commit 94b8d33 into master Aug 5, 2020
@spinkelman spinkelman deleted the feature/add_application_type_picklist_values branch August 5, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants