Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Robot] Disbursement permission test #99

Merged
merged 10 commits into from
Mar 20, 2021

Conversation

gaganpsandhu
Copy link
Contributor

@gaganpsandhu gaganpsandhu commented Mar 19, 2021

WI: https://gus.lightning.force.com/a07B0000008xooeIAA

Critical Changes

Changes

Issues Closed

New Metadata

Deleted Metadata

Definition of Done

Refer to Definition of Done to see any additional details for the items below:

  • Any net new LWC work has JEST test coverage 50% or above
  • Default Sa11y tests pass for all LWC components
  • 🔒 Secure both Front-end (LWC) & back-end (Apex) as necessary
  • 🔑 Grant users access in Permission Sets (Object, Field, Apex Class) as necessary
  • Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name
  • Make sure that ACs are updated (if any gaps)
  • All acceptance criteria have been met
    • Developer
    • Code Reviewer
  • Pull Request contains draft release notes
  • Labels, help text, and customer facing messages are reviewed by Docs
  • QE story level testing completed

Unaggregated Pull Requests

  • Adds namespace tokens to unmanaged references [PR100]

@gaganpsandhu gaganpsandhu requested a review from a team as a code owner March 19, 2021 00:56
spelak-salesforce and others added 3 commits March 19, 2021 12:05
- `unpackaged/qa/permissionsets/Disbursements.permissionset-meta.xml`
- CumulusCI task `delete_data`
…rsementpermission__namespace

Adds namespace tokens to unmanaged references
@gaganpsandhu
Copy link
Contributor Author

link to WI- W-9027758

@gaganpsandhu
Copy link
Contributor Author

@jstvz This is ready for your review.

@gaganpsandhu gaganpsandhu requested a review from jstvz March 19, 2021 16:38
Copy link
Contributor

@spelak-salesforce spelak-salesforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Approving.

I was considering if all the extra files for robot tests should go in a sub-directory of robot/OutboundFunds/resources to keep all the config in one place. Though what you have is fine too.

cumulusci.yml Outdated
Comment on lines 83 to 86
6:
task: assign_permission_sets
options:
api_names: Disbursements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed since you added "permsets": ["Disbursements"] to the user definition file.

Suggested change
6:
task: assign_permission_sets
options:
api_names: Disbursements

@gaganpsandhu gaganpsandhu merged commit 7ceb935 into master Mar 20, 2021
@gaganpsandhu gaganpsandhu deleted the feature/robot_disbursementpermission branch March 20, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants