Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RE codeowners PR workflow #156

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Conversation

jstvz
Copy link
Member

@jstvz jstvz commented Sep 20, 2021

This PR adds a new organization workflow using the SalesforceFoundation/github-script action that will add comments to PRs on the following events:

  1. A review request (pull_request.review_requested) from a given CODEOWNERS github team (release-engineering-reviewers).
  2. A user adds the "ready for RE review" label (pull_request.review_requested) to a pull request.

Critical Changes

Changes

Issues Closed

New Metadata

Deleted Metadata

Definition of Done

Refer to Definition of Done to see any additional details for the items below:

  • Any net new LWC work has JEST test coverage 50% or above
  • Default Sa11y tests pass for all LWC components
  • 🔒 Secure both Front-end (LWC) & back-end (Apex) as necessary
  • 🔑 Grant users access in Permission Sets (Object, Field, Apex Class) as necessary
  • Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name
  • Make sure that ACs are updated (if any gaps)
  • All acceptance criteria have been met
    • Developer
    • Code Reviewer
  • Pull Request contains draft release notes
  • Labels, help text, and customer facing messages are reviewed by Docs
  • QE story level testing completed

This PR adds a new organization workflow using the SalesforceFoundation/github-script action that will add comments to PRs on the following events:

1. A review request (pull_request.review_requested) from a given CODEOWNERS github team (release-engineering-reviewers).
2. A user adds the "ready for RE review" label (pull_request.review_requested) to a pull request.
@jstvz jstvz requested a review from a team as a code owner September 20, 2021 22:50
@jstvz jstvz requested a review from jofsky September 20, 2021 22:50
@github-actions
Copy link

Hi 👋 @jstvz! Release Engineering asks that teams use the following process for routine reviews:

  1. After creating a non-draft pull request that includes automation updates, a release engineer will be auto-assigned to the PR.
  2. When dev review is complete and the PR is ready for the release engineer to review, add a "ready for RE review" label to the PR to let us know when the PR is ready for us to review.
  3. If you've added the "ready for RE review" label but haven't received a review within a 36 hours, @-mention the assigned RE in a comment on the PR.
  4. If you don't receive a response from the assigned RE by the end of the next business day (or your request is urgent), post a message to #sfdo-releng-support that includes a link to this PR and one of us will review as soon as we're able.

@jstvz jstvz added the ready for RE review This PR is ready for RE review. Used in CI. label Sep 20, 2021
@github-actions
Copy link

This PR has been labeled as ready for Release Engineering review by
@jstvz. Reviews have been requested from: @jofsky.

@jstvz jstvz removed the ready for RE review This PR is ready for RE review. Used in CI. label Sep 27, 2021
This commit switches the existing RelEng workflow to use the new GitHub
Actions feature to source a workflow [1] stored in another repository
(see also: [2]).

[1]: https://docs.github.com/en/actions/learn-github-actions/reusing-workflows
[2]: https://github.com/SalesforceFoundation/.github/blob/main/docs/workflows.md
@jstvz jstvz merged commit 7f09566 into master Oct 13, 2021
@jstvz jstvz deleted the feature/add-codeowners-workflow branch October 13, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants